8000 bpo-24959: fix unittest.assertRaises bug where traceback entries are dropped from chained exceptions by iritkatriel · Pull Request #23688 · python/cpython · GitHub
[go: up one dir, main page]
Skip to content

bpo-24959: fix unittest.assertRaises bug where traceback entries are dropped from chained exceptions #23688

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
Mar 8, 2022
Merged

bpo-24959: fix unittest.assertRaises bug where traceback entries are dropped from chained exceptions #23688

Changes from 1 commit
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
f642752
bpo-42247: fix unittest.assertRaises bug where traceback entries were…
iritkatriel Dec 8, 2020
e0c8019
Update Lib/unittest/test/test_result.py
iritkatriel Sep 5, 2021
6bca38a
Update Lib/unittest/test/test_result.py
iritkatriel Sep 5, 2021
b60a829
Update Lib/unittest/test/test_result.py
iritkatriel Sep 5, 2021
7274a04
rewrite test
iritkatriel Sep 6, 2021
d067f50
clean tracebacks for chained exceptions as well
iritkatriel Sep 6, 2021
4ae0bf0
📜🤖 Added by blurb_it.
blurb-it[bot] Sep 6, 2021
d51e954
Merge remote-tracking branch 'upstream/main' into bpo-42247
iritkatriel Mar 8, 2022
9290967
newline
iritkatriel Mar 8, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
rewrite test
  • Loading branch information
@iritkatriel
iritkatriel committed Sep 6, 2021
commit 7274a04656e0e98a0d1c1201f8a4c3e79d6d29e9
67 changes: 26 additions & 41 deletions Lib/unittest/test/test_result.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -204,6 +204,32 @@ def test_1(self):
self.assertIs(test_case, test)
self.assertIsInstance(formatted_exc, str)

def test_addFailure_filter_traceback_frames(self):
class Foo(unittest.TestCase):
def test_1(self):
pass

test = Foo('test_1')
def get_exc_info():
try:
test.fail("foo")
except:
return sys.exc_info()

exc_info_tuple = get_exc_info()

full_exc = traceback.format_exception(*exc_info_tuple)

result = unittest.TestResult()
result.startTest(test)
result.addFailure(test, exc_info_tuple)
result.stopTest(test)

formatted_exc = result.failures[0][1]
dropped = [l for l in full_exc if l not in formatted_exc]
self.assertEqual(len(dropped), 1)
self.assertIn("raise self.failureException(msg)", dropped[0])

# "addError(test, err)"
# ...
# "Called when the test case test raises an unexpected exception err
Expand Down Expand Up @@ -424,47 +450,6 @@ class tb_frame(object):
Frame.tb_frame.f_globals['__unittest'] = True
self.assertTrue(result._is_relevant_tb_level(Frame))

def testRemoveUnittestTbFrames(self):
try:
self.fail('too bad')
except self.failureException:
exc_info = sys.exc_info()
tb = exc_info[2]
self.assertEqual(len(list(traceback.walk_tb(tb))), 2)
result = unittest.TestResult()
result._remove_unittest_tb_frames(tb)
self.assertEqual(len(list(traceback.walk_tb(tb))), 1)

def testExcInfoStringChained(self): # bpo 49563
def raiseAnException():
raise ValueError(42)
try:
try:
raiseAnException()
except ValueError:
self.fail('too bad')
except self.failureException:
exc_info = sys.exc_info()

class ResultWithoutFilter(unittest.TestResult):
def _remove_unittest_tb_frames(self, tb):
pass

result = ResultWithoutFilter()
exc_str_no_filter = result._exc_info_to_string(exc_info, self)

result = unittest.TestResult()
exc_str_filtered = result._exc_info_to_string(exc_info, self)
for exc_str in [exc_str_no_filter, exc_str_filtered]:
self.assertIn('raiseAnException()', exc_str)
self.assertIn('raise ValueError(42)', exc_str)
self.assertIn("self.fail('too bad')", exc_str)
self.assertIn('AssertionError: too bad', exc_str)

# The unittest call:
self.assertNotIn('raise self.failureException(msg)', exc_str_filtered)
self.assertIn('raise self.failureException(msg)', exc_str_no_filter)

def testFailFast(self):
result = unittest.TestResult()
result._exc_info_to_string = lambda *_: ''
Expand Down
0