10000 [3.9] bpo-42576: Raise TypeError when passing in keyword arguments to GenericAlias (GH-23656) by miss-islington · Pull Request #23659 · python/cpython · GitHub
[go: up one dir, main page]
Skip to content

[3.9] bpo-42576: Raise TypeError when passing in keyword arguments to GenericAlias (GH-23656) #23659

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 5, 2020
Merged

[3.9] bpo-42576: Raise TypeError when passing in keyword arguments to GenericAlias (GH-23656) #23659

merged 1 commit into from
Dec 5, 2020

Conversation

miss-islington
Copy link
Contributor
@miss-islington miss-islington commented Dec 5, 2020 •
edited
Loading

Use _PyArg_NoKeywords instead of _PyArg_NoKwnames when checking the kwds tuple when creating GenericAlias. This fixes an interpreter crash when passing in keyword arguments to GenericAlias's constructor.

Needs backport to 3.9.

Automerge-Triggered-By: GH:gvanrossum
(cherry picked from commit 804d689)

Co-authored-by: kj 28750310+Fidget-Spinner@users.noreply.github.com

https://bugs.python.org/issue42576

Automerge-Triggered-By: GH:gvanrossum

@Fidget-Spinner @miss-islington
bpo-42576: Raise TypeError when passing in keyword arguments to Gener…
b2b2cef 
…icAlias (pythonGH-23656)

Use `_PyArg_NoKeywords` instead of `_PyArg_NoKwnames` when checking the `kwds` tuple when creating `GenericAlias`. This fixes an interpreter crash when passing in keyword arguments to `GenericAlias`'s constructor.

Needs backport to 3.9.

Automerge-Triggered-By: GH:gvanrossum
(cherry picked from commit 804d689)

Co-authored-by: kj <28750310+Fidget-Spinner@users.noreply.github.com>
@bedevere-bot bedevere-bot mentioned this pull request Dec 5, 2020
Merged
@miss-islington
Copy link
Contributor Author

@Fidget-Spinner: Status check is done, and it's a success ✅ .

1 similar comment
@miss-islington
Copy link
Contributor Author

@Fidget-Spinner: Status check is done, and it's a success ✅ .

@miss-islington
Copy link
Contributor Author

@Fidget-Spinner: Status check is done, and it's a success ✅ .

@miss-islington miss-islington merged commit d5c029b into python:3.9 Dec 5, 2020
@miss-islington miss-islington deleted the backport-804d689-3.9 branch December 5, 2020 16:24
@miss-islington
Copy link
Contributor Author

@Fidget-Spinner: Status check is done, and it's a success ✅ .

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gvanrossum gvanrossum gvanrossum approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@miss-islington @gvanrossum @the-knights-who-say-ni @bedevere-bot @Fidget-Spinner
0