8000 [security][3.3] bpo-30730: Prevent environment variables injection in subprocess on Windows. (GH-2325) by serhiy-storchaka · Pull Request #2363 · python/cpython · GitHub
[go: up one dir, main page]
Skip to content

[security][3.3] bpo-30730: Prevent environment variables injection in subprocess on Windows. (GH-2325) #2363

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Jul 19, 2017
Merged

[security][3.3] bpo-30730: Prevent environment variables injection in subprocess on Windows. (GH-2325) #2363

merged 4 commits into from
Jul 19, 2017

Conversation

serhiy-storchaka
Copy link
Member

Prevent passing other invalid environment variables and command arguments..
(cherry picked from commit d174d24)

@mention-bot
Copy link

@serhiy-storchaka, thanks for your PR! By analyzing the history of the files in this pull request, we identified @gvanrossum, @gpshead and @tim-one to be potential reviewers.

@serhiy-storchaka
[3.3] bpo-30730: Prevent environment variables injection in subproces…
84bfcb8 
…s on Windows. (pythonGH-2325)

Prevent passing other invalid environment variables and command arguments..
(cherry picked from commit d174d24)
@vstinner vstinner changed the title [3.3] bpo-30730: Prevent environment variables injection in subprocess on Windows. (GH-2325) [security][3.3] bpo-30730: Prevent environment variables injection in subprocess on Windows. (GH-2325) Jun 28, 2017
@vstinner vstinner requested a review from ned-deily June 28, 2017 14:42
A1B1
@vstinner vstinner mentioned this pull request Jul 13, 2017
Merged
@ned-deily ned-deily merged commit e46f1c1 into python:3.3 Jul 19, 2017
@ned-deily ned-deily removed their request for review July 19, 2017 02:41
@serhiy-storchaka serhiy-storchaka deleted the backport-d174d24-3.3 branch August 9, 2017 12:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vstinner vstinner vstinner approved these changes

Assignees
No one assigned
Labels
OS-windows type-security A security issue
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@serhiy-storchaka @mention-bot @vstinner @ned-deily @the-knights-who-say-ni
0