8000 Fix indentation for get_stats_profile() docs. by msuozzo · Pull Request #23618 · python/cpython · GitHub
[go: up one dir, main page]

Skip to content

Fix indentation for get_stats_profile() docs. #23618

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 16, 2020

Conversation

msuozzo
Copy link
Contributor
@msuozzo msuozzo commented Dec 2, 2020

The existing method is indented one too many times which makes it look like a sub-method of print_callees()

The existing method is indented one too many times which makes it look like a sub-method of print_callees()
Copy link
Member
@Fidget-Spinner Fidget-Spinner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. The original docs is indeed indented too much as seen here https://docs.python.org/3.10/library/profile.html#pstats.Stats.get_stats_profile .

Thank you for the PR!

@miss-islington
Copy link
Contributor

Thanks @msuozzo for the PR, and @berkerpeksag for merging it 🌮🎉.. I'm working now to backport this PR to: 3.9.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Dec 16, 2020
The existing method is indented one too many times which
makes it look like a sub-method of print_callees().
(cherry picked from commit a6ba2b9)

Co-authored-by: Matthew Suozzo <msuozzo@google.com>
@bedevere-bot
Copy link

GH-23810 is a backport of this pull request to the 3.9 branch.

@bedevere-bot bedevere-bot removed the needs backport to 3.9 only security fixes label Dec 16, 2020
berkerpeksag pushed a commit that referenced this pull request Dec 16, 2020
The existing method is indented one too many times which
makes it look like a sub-method of print_callees().
(cherry picked from commit a6ba2b9)

Co-authored-by: Matthew Suozzo <msuozzo@google.com>
adorilson pushed a commit to adorilson/cpython that referenced this pull request Mar 13, 2021
The existing method is indented one too many times which
makes it look like a sub-method of print_callees().
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Documentation in the Doc dir skip issue skip news
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants
0