8000 bpo-31904: posixpath.expanduser() handles user home of None by pxinwr · Pull Request #23530 · python/cpython · GitHub
[go: up one dir, main page]
Skip to content

bpo-31904: posixpath.expanduser() handles user home of None #23530

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Dec 17, 2020
Merged

bpo-31904: posixpath.expanduser() handles user home of None #23530

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
06d9815
* posixpath.expanduser() returns the input path unchanged if
pxinwr Nov 27, 2020
fc41230
add news
pxinwr Nov 27, 2020
0665512
revert the fix from test_pathlib.py and test_posixpath.py
pxinwr Dec 15, 2020
2ab98e9
limit the behaviour of no user home to only on VxWorks
pxinwr Dec 17, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions Lib/posixpath.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -262,6 +262,9 @@ def expanduser(path):
# password database, return the path unchanged
return path
userhome = pwent.pw_dir
# if the current user has no home directory, return the path unchanged
if userhome is None:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not comfortable to change the behavior on any platform.

I would be ok if the change is specific to VxWorks, if you add:

Suggested change
if userhome is None:
if userhome is None and sys.platform == "vxworks":

Please update the comment and the NEWS entry to mention that only VxWorks is impacted.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

modified.

return path
if isinstance(path, bytes):
userhome = os.fsencode(userhome)
root = b'/'
Expand Down
2 changes: 2 additions & 0 deletions Misc/NEWS.d/next/Library/2020-11-27-18-09-59.bpo-31904.g8k43d.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
:func:`posixpath.expanduser` returns the input *path* unchanged if
user home directory is None.
0