8000 bpo-42333: Port _ssl extension module to heap types (GH-23392) by tiran · Pull Request #23392 · python/cpython · GitHub
[go: up one dir, main page]
Skip to content

bpo-42333: Port _ssl extension module to heap types (GH-23392) #23392

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Nov 20, 2020
Merged

bpo-42333: Port _ssl extension module to heap types (GH-23392) #23392

merged 6 commits into from
Nov 20, 2020

Conversation

tiran
Copy link
Member
@tiran tiran commented Nov 19, 2020 •
edited by bedevere-bot
Loading

@tiran tiran requested a review from vstinner November 19, 2020 08:51
@tiran
Copy link
Member Author
tiran commented Nov 19, 2020

The PR does not introduce PyModule_AddObjectRef() or error checks to PyModule_AddIntConstant(). I'll update the code once my constant initialization feature has landed.

@tiran tiran requested a review from corona10 November 19, 2020 14:17
@tiran tiran changed the title bpo-42333: Port _ssl extension module to heap types bpo-42333: Port _ssl extension module to heap types (GH-23392) Nov 20, 2020
@tiran tiran merged commit 5c36da7 into python:master Nov 20, 2020
@tiran tiran deleted the bpo-42333-ssl-init branch November 20, 2020 08:40
adorilson pushed a commit to adorilson/cpython that referenced this pull request Mar 13, 2021
@tiran @adorilson
bpo-42333: Port _ssl extension module to heap types (pythonGH-23392)
49203eb 
All types in _ssl module are now heap types.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vstinner vstinner Awaiting requested review from vstinner

@corona10 corona10 Awaiting requested review from corona10

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tiran @the-knights-who-say-ni @bedevere-bot
0