10000 bpo-24813: IDLE: Add icon to help_about by csabella · Pull Request #2335 · python/cpython · GitHub
[go: up one dir, main page]
Skip to content

bpo-24813: IDLE: Add icon to help_about #2335

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jun 23, 2017
Merged

bpo-24813: IDLE: Add icon to help_about #2335

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
c4abf7a
bpo-24813: IDLE: Add icon to help_about
csabella Jun 23, 2017
58dbd10
bpo-24813: IDLE: Add icon to help_about
csabella Jun 23, 2017
3b456dc
bpo-24813: IDLE: Add icon to help_about
csabella Jun 23, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
bpo-24813: IDLE: Add icon to help_about
  • Loading branch information
@csabella
csabella committed Jun 23, 2017
commit c4abf7ad0749bd9ed97b5a2c7704945c3d7d646c
14 changes: 11 additions & 3 deletions Lib/idlelib/help_about.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,8 +4,8 @@
import os
from sys import version

from tkinter import Toplevel, Frame, Label, Button
from tkinter import SUNKEN, TOP, BOTTOM, LEFT, X, BOTH, W, EW, NSEW
from tkinter import Toplevel, Frame, Label, Button, PhotoImage
from tkinter import SUNKEN, TOP, BOTTOM, LEFT, X, BOTH, W, EW, NSEW, NE

from idlelib import textview

Expand Down Expand Up @@ -63,6 +63,15 @@ def create_widgets(self):
header = Label(frame_background, text='IDLE', fg=self.fg,
bg=self.bg, font=('courier', 24, 'bold'))
header.grid(row=0, column=0, sticky=W, padx=10, pady=10)

tk_patchlevel = self.tk.call('info', 'patchlevel')
ext = '.png' if tk_patchlevel >= '8.6' else '.gif'
iconfn = os.path.join(os.path.abspath(os.path.dirname(__file__)),
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suspect 'iconfn' abbreviates 'icon file name'. Too obscure; I'd prefer 'icon' here and below.

'Icons', f'idle_48{ext}')
self.icon_image = PhotoImage(master=self._root(), file=iconfn)
logo = Label(frame_background, image=self.icon_image, bg=self.bg)
logo.grid(row=0, column=0, sticky=NE, rowspan=2, padx=10, pady=10)

byline_text = "Python's Integrated DeveLopment Environment" + 5*'\n'
byline = Label(frame_background, text=byline_text, justify=LEFT,
fg=self.fg, bg=self.bg)
Expand All @@ -82,7 +91,6 @@ def create_widgets(self):
pyver = Label(frame_background, text='Python version: ' + release,
fg=self.fg, bg=self.bg)
pyver.grid(row=9, column=0, sticky=W, padx=10, pady=0)
tk_patchlevel = self.tk.call('info', 'patchlevel')
tkver = Label(frame_background, text='Tk version: ' + tk_patchlevel,
fg=self.fg, bg=self.bg)
tkver.grid(row=9, column=1, sticky=W, padx=2, pady=0)
Expand Down
8 changes: 8 additions & 0 deletions Lib/idlelib/idle_test/test_help_about.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,10 +5,12 @@
from test.support import requires, findfile
from tkinter import Tk, TclError
import unittest
from unittest import mock
from idlelib.idle_test.mock_idle import Func
from idlelib.idle_test.mock_tk import Mbox_func
from idlelib.help_about import AboutDialog as About
from idlelib import textview
import os.path

class LiveDialogTest(unittest.TestCase):
"""Simulate user clicking buttons other than [Close].
Expand All @@ -33,6 +35,12 @@ def test_dialog_title(self):
"""Test about dialog title"""
self.assertEqual(self.dialog.title(), 'About IDLE')

def test_dialog_logo(self):
"""Test about dialog logo."""
path, file = os.path.split(self.dialog.icon_image['file'])
fn, ext = os.path.splitext(file)
self.assertEqual(fn, 'idle_48')
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is the best I can think of too. The real test is running help_about for the htest. I did that to experiment with different backgrounds.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. I wasn't sure if I should mock the PhotoImage just to show that the widget is created.


def test_printer_buttons(self):
"""Test buttons whose commands use printer function."""
dialog = self.dialog
Expand Down
0