8000 bpo-42344: Improve pseudo implementation for SimpleNamespace by jugmac00 · Pull Request #23264 · python/cpython · GitHub
[go: up one dir, main page]
Skip to content

bpo-42344: Improve pseudo implementation for SimpleNamespace #23264

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Nov 13, 2020
Merged

bpo-42344: Improve pseudo implementation for SimpleNamespace #23264

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
669a207
bpo-38914: Improve pseudo implementation for SimpleNamespace
jugmac00 Nov 13, 2020
0c03224
Apply suggested changes
jugmac00 Nov 13, 2020
c07831d
Apply requested changes
jugmac00 Nov 13, 2020
bf765fc
Apply requested changes
jugmac00 Nov 13, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Apply requested changes
  • Loading branch information
@jugmac00
jugmac00 committed Nov 13, 2020
commit bf765fc1959aea9ccd4cce7ab0e5c510ba995f08
2 changes: 1 addition & 1 deletion Doc/library/types.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -409,7 +409,7 @@ Additional Utility Classes and Functions
return "{}({})".format(type(self).__name__, ", ".join(items))

def __eq__(self, other):
if isinstance(other, SimpleNamespace):
if isinstance(self, SimpleNamespace) and isinstance(other, SimpleNamespace):
return self.__dict__ == other.__dict__
return NotImplemented

Expand Down
0