8000 bpo-42085: Fix memory leak introduced by GH-22780 by asvetlov · Pull Request #23237 · python/cpython · GitHub
[go: up one dir, main page]
Skip to content

bpo-42085: Fix memory leak introduced by GH-22780 #23237 < 8000 /h1>
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merged
merged 1 commit into from
Nov 11, 2020
Merged

bpo-42085: Fix memory leak introduced by GH-22780 #23237

merged 1 commit into from
Nov 11, 2020

Conversation

asvetlov
Copy link
Contributor
@asvetlov asvetlov commented Nov 11, 2020 •
edited by bedevere-bot
Loading

./python -m test test_asyncgen -R 3:3 -m test.test_asyncgen.AsyncGenAsyncioTest.test_async_gen_asyncio_03 doesn't report about leaks now.

https://bugs.python.org/issue42085

@asvetlov asvetlov requested a review from 1st1 as a code owner November 11, 2020 15:02
@asvetlov
Copy link
Contributor Author

@vstinner FYI: I have a fix for the memory leak.
Thank you very much for pointing on the problem.
Would you review this PR (in case if it is urgent) or wait for @1st1 and others?

@vladima you would be interested in this PR as the author of the initial change.

@1st1
Copy link
Member
1st1 commented Nov 11, 2020

Thanks so much, Andrew!

@asvetlov asvetlov merged commit cda99b4 into python:master Nov 11, 2020
@asvetlov asvetlov deleted the memleak branch November 11, 2020 15:48
@asvetlov
Copy link
Contributor Author

Welcome!

@bedevere-bot
Copy link

⚠️⚠️⚠️ Buildbot failure ⚠️⚠️⚠️

Hi! The buildbot s390x RHEL8 LTO 3.x has failed when building commit cda99b4.

What do you need to do:

  1. Don't panic.
  2. Check the buildbot page in the devguide if you don't know what the buildbots are or how they work.
  3. Go to the page of the buildbot that failed (https://buildbot.python.org/all/#builders/567/builds/972) and take a look at the build logs.
  4. Check if the failure is related to this commit (cda99b4) or if it is a false positive.
  5. If the failure is related to this commit, please, reflect that on the issue and make a new Pull Request with a fix.

You can take a look at the buildbot page here:

https://buildbot.python.org/all/#builders/567/builds/972

Summary of the results of the build (if available):

== Tests result: ENV CHANGED ==

410 tests OK.

10 slowest tests:

  • test_concurrent_futures: 2 min 52 sec
  • test_peg_generator: 2 min 50 sec
  • test_gdb: 1 min 41 sec
  • test_multiprocessing_spawn: 1 min 12 sec
  • test_nntplib: 1 min 6 sec
  • test_multiprocessing_forkserver: 1 min 1 sec
  • test_multiprocessing_fork: 54.9 sec
  • test_signal: 49.5 sec
  • test_asyncio: 48.2 sec
  • test_tokenize: 35.1 sec

1 test altered the execution environment:
test_asyncio

14 tests skipped:
test_devpoll test_ioctl test_kqueue test_msilib test_nis
test_ossaudiodev test_startfile test_tix test_tk test_ttk_guionly
test_winconsoleio test_winreg test_winsound test_zipfile64

Total duration: 4 min 47 sec

Click to see traceback logs 
Traceback (most recent call last):
  File "/home/dje/cpython-buildarea/3.x.edelsohn-rhel8-z.lto/build/Lib/asyncio/sslproto.py", line 321, in __del__
    self.close()
  File "/home/dje/cpython-buildarea/3.x.edelsohn-rhel8-z.lto/build/Lib/asyncio/sslproto.py", line 316, in close
    self._ssl_protocol._start_shutdown()
  File "/home/dje/cpython-buildarea/3.x.edelsohn-rhel8-z.lto/build/Lib/asyncio/sslproto.py", line 590, in _start_shutdown
    self._abort()
  File "/home/dje/cpython-buildarea/3.x.edelsohn-rhel8-z.lto/build/Lib/asyncio/sslproto.py", line 731, in _abort
    self._transport.abort()
  File "/home/dje/cpython-buildarea/3.x.edelsohn-rhel8-z.lto/build/Lib/asyncio/selector_events.py", line 680, in abort
    self._force_close(None)
  File "/home/dje/cpython-buildarea/3.x.edelsohn-rhel8-z.lto/build/Lib/asyncio/selector_events.py", line 731, in _force_close
    self._loop.call_soon(self._call_connection_lost, exc)
  File "/home/dje/cpython-buildarea/3.x.edelsohn-rhel8-z.lto/build/Lib/asyncio/base_events.py", line 746, in call_soon
    self._check_closed()
  File "/home/dje/cpython-buildarea/3.x.edelsohn-rhel8-z.lto/build/Lib/asyncio/base_events.py", line 510, in _check_closed
    raise RuntimeError('Event loop is closed')
RuntimeError: Event loop is closed

@asvetlov
Copy link
Contributor Author

I'm very sorry for the failure; it is not related to the change.

Heh, I should finish #17975 to fix this annoying sslproto issue.
8000

@1st1
Copy link
Member
1st1 commented Nov 11, 2020

Heh, I should finish #17975 to fix this annoying sslproto issue.

We're almost there!

adorilson pushed a commit to adorilson/cpython that referenced this pull request Mar 13, 2021
@asvetlov @adorilson
Fix memory leak introduced by pythonGH-22780 (pythonGH-23237)
6092a81
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@1st1 1st1 1st1 approved these changes

Assignees
No one assigned
Labels
skip news
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@asvetlov @1st1 @bedevere-bot @the-knights-who-say-ni
31A5
0