8000 bpo-40170: Hide implementation detail of Py_TRASHCAN_BEGIN macro by shihai1991 · Pull Request #23235 · python/cpython · GitHub
[go: up one dir, main page]
Skip to content

bpo-40170: Hide implementation detail of Py_TRASHCAN_BEGIN macro #23235

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Nov 24, 2020
Merged

bpo-40170: Hide implementation detail of Py_TRASHCAN_BEGIN macro #23235

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
8ab6dc8
Use PyType_GetSlot() in Py_TRASHCAN_BEGIN macro.
shihai1991 Nov 11, 2020
b288c3e
add the _PyTrash_cond() function
shihai1991 Nov 12, 2020
a0c82d7
apply victor's comment
shihai1991 Nov 13, 2020
3d2f872
apply victor's comment
shihai1991 Nov 13, 2020
db2d98c
apply victor's comment
shihai1991 Nov 13, 2020
477dbd8
apply victor's comment
shihai1991 Nov 24, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
DD86
Diff view
Diff view
2 changes: 1 addition & 1 deletion Include/cpython/object.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -538,7 +538,7 @@ PyAPI_FUNC(void) _PyTrash_end(struct _ts *tstate);

#define Py_TRASHCAN_BEGIN(op, dealloc) \
Py_TRASHCAN_BEGIN_CONDITION(op, \
Py_TYPE(op)->tp_dealloc == (destructor)(dealloc))
PyType_GetSlot(Py_TYPE(op), Py_tp_dealloc) == (destructor)(dealloc))

/* For backwards compatibility, these macros enable the trashcan
* unconditionally */
Expand Down
0