8000 gh-86457: Fix signature for code.replace(). by serhiy-storchaka · Pull Request #23199 · python/cpython · GitHub
[go: up one dir, main page]
Skip to content

gh-86457: Fix signature for code.replace(). #23199

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Aug 7, 2023
Merged

gh-86457: Fix signature for code.replace(). #23199

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
748a7e8
gh-86457: Fix signature for code.replace().
serhiy-storchaka Jul 9, 2020
1f828d4
Merge branch 'main' into clinic-code-replace
serhiy-storchaka Jun 29, 2023
65a165b
Completely override signature.
serhiy-storchaka Jun 29, 2023
bd423b2
Merge branch 'main' into clinic-code-replace
serhiy-storchaka Jun 29, 2023
4ddf714
Merge branch 'main' into clinic-code-replace
serhiy-storchaka Aug 7, 2023
f58f926
Fix MyPy complain.
serhiy-storchaka Aug 7, 2023
7b8791f
Add a NEWS entry.
serhiy-storchaka Aug 7, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Merge branch 'main' into clinic-code-replace
  • Loading branch information
@serhiy-storchaka
serhiy-storchaka committed Jun 29, 2023
commit 1f828d470101b476837b44d99448bfcc784266a3
2 changes: 1 addition & 1 deletion Objects/clinic/codeobject.c.h
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

5 changes: 4 additions & 1 deletion Tools/clinic/clinic.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2752,7 +2752,10 @@ def __init__(self,
self.unused = unused

if default is not unspecified and (default is not NULL or c_default == 'NULL'):
if self.default_type and not isinstance(default, (self.default_type, Unknown)):
if (self.default_type
and default is not unknown
and not isinstance(default, self.default_type)
):
if isinstance(self.default_type, type):
types_str = self.default_type.__name__
else:
Expand Down
You are viewing a condensed version of this merge commit. You can view the full changes here.
0