8000 bpo-1635741: _sqlite3 uses PyModule_AddObjectRef by erlend-aasland · Pull Request #23148 · python/cpython · GitHub
[go: up one dir, main page]
Skip to content

bpo-1635741: _sqlite3 uses PyModule_AddObjectRef #23148

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Nov 4, 2020
Merged

bpo-1635741: _sqlite3 uses PyModule_AddObjectRef #23148

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
c062592
Use PyModule_AddObjectRef iso. PyModule_AddObject in _sqlite3
Nov 4, 2020
590d11d
Address review comment: Use intermingled variable declarations
Nov 4, 2020
23ba6fa
Update Modules/_sqlite/module.c
Nov 4, 2020
cdae05e
Address review comment: Remove useless incref/decref
Nov 4, 2020
911ee5a
Address review comment: Use intermingled variable declarations
Nov 4, 2020
a4bb4bf
Address review comment: Use intermingled variable declarations again
Nov 4, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Address review comment: Use intermingled variable declarations again
  • Loading branch information
Erlend E. Aasland committed Nov 4, 2020
commit a4bb4bff76c1db364b1042c6191c6ac2a0004bd1
3 changes: 1 addition & 2 deletions Modules/_sqlite/module.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -357,12 +357,11 @@ do { \

#define ADD_EXCEPTION(module, name, exc, base) \
do { \
int res; \
exc = PyErr_NewException(MODULE_NAME "." name, base, NULL); \
if (!exc) { \
goto error; \
} \
res = PyModule_AddObjectRef(module, name, exc); \
int res = PyModule_AddObjectRef(module, name, exc); \
Py_DECREF(exc); \
if (res < 0) { \
goto error; \
Expand Down
0