8000 bpo-42047: DragonFlyBSD thread native id support. by devnexen · Pull Request #22714 · python/cpython · GitHub
[go: up one dir, main page]
Skip to content

bpo-42047: DragonFlyBSD thread native id support. #22714

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 8 commits into from
May 18, 2022
Merged

bpo-42047: DragonFlyBSD thread native id support. #22714

merged 8 commits into from
May 18, 2022

Conversation

devnexen
Copy link
Contributor
@devnexen devnexen commented Oct 15, 2020 •
edited by bedevere-bot
Loading

Fidget-Spinner
Fidget-Spinner reviewed Oct 16, 2020
View reviewed changes
Copy link
Member
@Fidget-Spinner Fidget-Spinner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just one minor nitpick on news

@devnexen @Fidget-Spinner
Update Misc/NEWS.d/next/Library/2020-10-15-18-37-12.bpo-42047.XDdoSF.rst
ba9f74a 
Co-authored-by: kj <28750310+Fidget-Spinner@users.noreply.github.com>
@github-actions
Copy link

This PR is stale because it has been open for 30 days with no activity. Remove stale label or comment or this will be closed in 5 days

@github-actions github-actions bot added the stale Stale PR or inactive for long period of time. label Dec 16, 2020
@devnexen
Copy link
Contributor Author

ping :)

@github-actions github-actions bot removed the stale Stale PR or inactive for long period of time. label Dec 17, 2020
erlend-aasland
erlend-aasland reviewed May 18, 2022
View reviewed changes
vstinner
vstinner reviewed May 18, 2022
View reviewed changes
@erlend-aasland @vstinner
Break long line
5a54ad2 
Co-authored-by: Victor Stinner <vstinner@python.org>
@erlend-aasland
Copy link
Contributor

Please also update the availability annotation of get_native_id in the docs:

  • Doc/library/_thread.rst
  • Doc/library/threading.rst

See gh-13624 for inspiration :)

@erlend-aasland erlend-aasland self-assigned this May 18, 2022
erlend-aasland
erlend-aasland requested changes May 18, 2022
View reviewed changes
Copy link
Contributor
@erlend-aasland erlend-aasland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please resolve #22714 (comment)

@bedevere-bot
Copy link

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.

erlend-aasland
erlend-aasland reviewed May 18, 2022
View reviewed changes
@devnexen
Copy link
Contributor Author
8000 devnexen commented May 18, 2022

I have made the requested changes; please review again.

@bedevere-bot
Copy link

Thanks for making the requested changes!

@erlend-aasland, @Fidget-Spinner: please review the changes made to this pull request.

@erlend-aasland erlend-aasland merged commit 9a1adf2 into python:main May 18, 2022
@erlend-aasland
Copy link
Contributor

Thanks, @devnexen!

@erlend-aasland erlend-aasland mentioned this pull request May 18, 2022
Closed
@vstinner
Copy link
Member

Maybe POSIX should do something and create a portable API for this function :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vstinner vstinner vstinner left review comments

@erlend-aasland erlend-aasland erlend-aasland approved these changes

@Fidget-Spinner Fidget-Spinner Awaiting requested review from Fidget-Spinner

Assignees

@erlend-aasland erlend-aasland

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@devnexen @erlend-aasland @bedevere-bot @vstinner @Fidget-Spinner @the-knights-who-say-ni
0