8000 Fix typo in "Context manager types" section in typing.rst by gousaiyang · Pull Request #22676 · python/cpython · GitHub
[go: up one dir, main page]
Skip to content

Fix typo in "Context manager types" section in typing.rst #22676

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 12, 2020
Merged

Fix typo in "Context manager types" section in typing.rst #22676

merged 1 commit into from
Oct 12, 2020

Conversation

gousaiyang
Copy link
Contributor
@gousaiyang gousaiyang commented Oct 12, 2020 •
edited by miss-islington
Loading

Fix typo in the "Context manager types" section in typing.rst.

Automerge-Triggered-By: @gvanrossum

@bedevere-bot bedevere-bot added docs Documentation in the Doc dir awaiting review labels Oct 12, 2020
gvanrossum
gvanrossum approved these changes Oct 12, 2020
View reviewed changes
Copy link
Member
@gvanrossum gvanrossum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Good eye.

@gvanrossum
Copy link
Member

It's possible that the Travis-CI build will hang (this is a bug somewhere between GitHub and Travis-CI). If that appears the case please ping the issue again and I'll force the merge.

@miss-islington
Copy link
Contributor

@gousaiyang: Status check is done, and it's a success ✅ .

@miss-islington miss-islington merged commit ba06a70 into python:master Oct 12, 2020
@miss-islington
Copy link
Contributor

Thanks @gousaiyang for the PR 🌮🎉.. I'm working now to backport this PR to: 3.8, 3.9.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Oct 12, 2020
@gousaiyang @miss-islington
Fix typo in "Context manager types" section in typing.rst (pythonGH-2…
5b1a2e2 
…2676)

Fix typo in the "Context manager types" section in `typing.rst`.

Automerge-Triggered-By: @gvanrossum
(cherry picked from commit ba06a70)

Co-authored-by: Saiyang Gou <gousaiyang@163.com>
@bedevere-bot
Copy link

GH-22678 is a backport of this pull request to the 3.9 branch.

@bedevere-bot bedevere-bot removed the needs backport to 3.9 only security fixes label Oct 12, 2020
@miss-islington
Copy link
Contributor

Sorry, @gousaiyang, I could not cleanly backport this to 3.8 due to a conflict.
Please backport using cherry_picker on command line.
cherry_picker ba06a70c822ede62688136add488eb78957689fe 3.8

@miss-islington miss-islington self-assigned this Oct 12, 2020
@gousaiyang
Copy link
Contributor Author

The 3.8 backport is unnecessary since the relevant documentation part was not present in 3.8.

@gousaiyang gousaiyang deleted the typing-contextmanager-doc-fix branch October 12, 2020 23:41
miss-islington added a commit that referenced this pull request Oct 12, 2020
@miss-islington @gousaiyang
Fix typo in "Context manager types" section in typing.rst (GH-22676)
15ef19f 
Fix typo in the "Context manager types" section in `typing.rst`.

Automerge-Triggered-By: @gvanrossum
(cherry picked from commit ba06a70)

Co-authored-by: Saiyang Gou <gousaiyang@163.com>
xzy3 pushed a commit to xzy3/cpython that referenced this pull request Oct 18, 2020
@gousaiyang
Fix typo in "Context manager types" section in typing.rst (pythonGH-2…
9214f67 
…2676)

Fix typo in the "Context manager types" section in `typing.rst`.

Automerge-Triggered-By: @gvanrossum
adorilson pushed a commit to adorilson/cpython that referenced this pull request Mar 13, 2021
@gousaiyang @adorilson
Fix typo in "Context manager types" section in typing.rst (pythonGH-2…
8f927c0 
…2676)

Fix typo in the "Context manager types" section in `typing.rst`.

Automerge-Triggered-By: @gvanrossum
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gvanrossum gvanrossum gvanrossum approved these changes

@ilevkivskyi ilevkivskyi Awaiting requested review from ilevkivskyi

Assignees

@miss-islington miss-islington

Labels
docs Documentation in the Doc dir skip issue skip news
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@gousaiyang @gvanrossum @miss-islington @bedevere-bot @the-knights-who-say-ni
0