8000 [Security][3.4] bpo-26657: Fix Windows directory traversal vulnerability with http.server by vstinner · Pull Request #226 · python/cpython · GitHub
[go: up one dir, main page]

Skip to content

[Security][3.4] bpo-26657: Fix Windows directory traversal vulnerability with http.server #226

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

vstinner
Copy link
Member

Issue #26657: Fix Windows directory traversal vulnerability with http.server

Based on patch by Philipp Hagemeister. This fixes a regression caused by revision f4377699fd47.

(cherry picked from commit d274b3f)

http://bugs.python.org/issue26657

Backport to 3.4 the fix of a security vulnerability:
http://python-security.readthedocs.io/vulnerabilities.html#issue-26657

This pull request is based on PR #224. It's the first time that I try to create a PR based on another one. Let's see how it works :-)

Misc/NEWS Outdated
@@ -70,6 +72,10 @@ Build
Tests
-----

- Issue #26657: Fix directory traversal vulnerability with http.server on
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't also this be in section "What's New in Python 3.4.7 release candidate 1"?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh right, it's a bug in my cherry pick :-/

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed

….server

Based on patch by Philipp Hagemeister.  This fixes a regression caused by
revision f4377699fd47.

(cherry picked from commit d274b3f)
@vstinner vstinner requested a review from larryhastings March 27, 2017 14:01
@vstinner vstinner changed the title Issue26657/3.4 [Security][3.4] bpo-26657: Fix Windows directory traversal vulnerability with http.server Mar 27, 2017
@vstinner
Copy link
Member Author

Oops, I backported the change twice. I abandon this one in favor of #782

@vstinner vstinner closed this Mar 27, 2017
@vstinner vstinner deleted the issue26657/3.4 branch August 10, 2017 23:37
akruis pushed a commit to akruis/cpython that referenced this pull request Aug 8, 2019
Apply the workaround from bpo-37788: join the created thread.
akruis pushed a commit to akruis/cpython that referenced this pull request May 27, 2021
Apply the workaround from bpo-37788: join the created thread.

(cherry picked from commit 6e15c22)
jaraco pushed a commit that referenced this pull request Dec 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type-security A security issue
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants
0