-
-
Notifications
You must be signed in to change notification settings - Fork 32.4k
bpo-41905: added abc.update_abstractmethods #22485
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 1 commit
Commits
Show all changes
21 commits
Select commit
Hold shift + click to select a range
f65b0f8
added update_abstractmethods
c04ba74
📜🤖 Added by blurb_it.
blurb-it[bot] ea69ae6
fix whitespaces
8b76715
Merge branch 'master' of https://github.com/bentheiii/cpython into ma…
61c4f40
documentation fixes
a5a9fd7
additional tests
5e1fffc
rename test
2f95b84
added explicit check for ABCMeta
3986c98
optimization on total_ordering
4f3d846
update_abstractmethods now ignores non-abstract classes
74473c8
total_ordering now only overrides abtract methods defined in supercla…
92326c9
doc fix
1e47ee4
excluded total_ordering from this issue
740183f
documented ABC being ABC unaware
114028e
fixed potential bug with deletion of implementation
ba8df08
added layered test case
29dba37
update_abstractmethods doesn't care about subclasses for now
779e6cf
doc fixes
eea97f4
Update Doc/library/abc.rst
bentheiii 8eec6c2
Update Lib/abc.py
bentheiii 5698153
Update Lib/abc.py
bentheiii File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
additional tests
- Loading branch information
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think you need this test case to cover the first loop:
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@iritkatriel What does that test case accomplish other than showing that FooABC is now in an inconsistent state?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@gvanrossum In this comment I left out the update_abstractmethods, see Ben's version which he committed as test_update_del. Without this test the first loop in update_abstractmethods was not exercised.