8000 [3.6] bpo-30682: Removed a too-strict assertion that failed for certain f-strings. (GH-2232) by serhiy-storchaka · Pull Request #2242 · python/cpython · GitHub
[go: up one dir, main page]
Skip to content

[3.6] bpo-30682: Removed a too-strict assertion that failed for certain f-strings. (GH-2232) #2242

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 16, 2017
Merged

[3.6] bpo-30682: Removed a too-strict assertion that failed for certain f-strings. (GH-2232) #2242

merged 1 commit into from
Jun 16, 2017

Conversation

serhiy-storchaka
Copy link
Member

This caused a segfault on eval("f'\\n'") and eval("f'\\r'") in debug build..
(cherry picked from commit 11e97f2)

@ericvsmith @serhiy-storchaka
[3.6] bpo-30682: Removed a too-strict assertion that failed for certa…
1d588a2 
…in f-strings. (pythonGH-2
8000
232)

This caused a segfault on eval("f'\\\n'") and eval("f'\\\r'") in debug build..
(cherry picked from commit 11e97f2)
@serhiy-storchaka serhiy-storchaka added the type-security A security issue label Jun 16, 2017
@ned-deily
Copy link
Member

LGTM

@ericvsmith
Copy link
Member

Looks good to me, too.

@ericvsmith ericvsmith merged commit 2eca5b4 into python:3.6 Jun 16, 2017
@serhiy-storchaka serhiy-storchaka deleted the backport-11e97f2-3.6 branch August 9, 2017 12:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
type-security A security issue
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@serhiy-storchaka @ned-deily @ericvsmith @the-knights-who-say-ni
0