8000 bpo-29614: Rename and reimplement csv.DictReader. by foxfluff · Pull Request #223 · python/cpython · GitHub
[go: up one dir, main page]
Skip to content

bpo-29614: Rename and reimplement csv.DictReader. #223

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 4 commits into from
Closed

bpo-29614: Rename and reimplement csv.DictReader. #223

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
37927b2
#29614: Rename and reimplement DictReader. Added TableReader that of…
foxfluff Feb 21, 2017
9aa3d41
bpo-29614: Fix bugs based on test failures.
foxfluff Feb 21, 2017
55930fc
Additional fixes due to attempted usage of non integers for index ass…
foxfluff Feb 21, 2017
48d3ce1
Additional fixes based on testing failures. Originally implemented t…
foxfluff Feb 21, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
#29614: Rename and reimplement DictReader. Added TableReader that off… 
…ers non-destructive behavior for csv documents with duplicate fieldname values.
  • Loading branch information
@foxfluff
foxfluff committed Feb 21, 2017
commit 37927b21eb62e019c3bec326bdc9abd02245d499
13 changes: 9 additions & 4 deletions Lib/csv.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,8 +18,8 @@
"Error", "Dialect", "__doc__", "excel", "excel_tab",
"field_size_limit", "reader", "writer",
"register_dialect", "get_dialect", "list_dialects", "Sniffer",
"unregister_dialect", "__version__", "DictReader", "DictWriter",
"unix_dialect"]
"unregister_dialect", "__version__", "TableReader", "DictReader",
"DictWriter", "unix_dialect"]

class Dialect:
"""Describe a CSV dialect.
Expand Down Expand Up @@ -78,7 +78,7 @@ class unix_dialect(Dialect):
register_dialect("unix", unix_dialect)


class DictReader:
class TableReader:
def __init__(self, f, fieldnames=None, restkey=None, restval=None,
dialect="excel", *args, **kwds):
self._fieldnames = fieldnames # list of keys for the dict
Expand Down Expand Up @@ -117,7 +117,7 @@ def __next__(self):
# values
while row == []:
row = next(self.reader)
d = OrderedDict(zip(self.fieldnames, row))
d = tuple(zip(self.fieldnames, row))
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tests failed due to using tuple instead of list (as line 127 will attempt to write to what is now non-mutable)
Needs to be changed to list(zip...)

lf = len(self.fieldnames)
lr = len(row)
if lf < lr:
Expand All @@ -128,6 +128,11 @@ def __next__(self):
return d


class DictReader(TableReader):
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There would need to be a DeprecationWarning raised at some point here.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would a DeprecationWarning be appropriate here? as this ideally would not affect the behavior of DictReader, and would instead just add the "new" functionality of TableReader.

def __next__(self):
return OrderedDict(super().__next__())


class DictWriter:
def __init__(self, f, fieldnames, restval="", extrasaction="raise",
dialect="excel", *args, **kwds):
Expand Down
0