8000 bpo-40721: add note about enum member name case by ethanfurman · Pull Request #22231 · python/cpython · GitHub
[go: up one dir, main page]
Skip to content

bpo-40721: add note about enum member name case #22231

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Sep 14, 2020
Merged

bpo-40721: add note about enum member name case #22231

merged 2 commits into from
Sep 14, 2020

Conversation

ethanfurman
Copy link
Member
@ethanfurman ethanfurman commented Sep 13, 2020 •
edited by miss-islington
Loading

Which is that UPPER_CASE is preferred as enums are constants.

https://bugs.python.org/issue40721

@bedevere-bot bedevere-bot added docs Documentation in the Doc dir awaiting core review labels Sep 13, 2020
@ethanfurman ethanfurman self-assigned this Sep 13, 2020
@ethanfurman ethanfurman merged commit 542e1df into python:master Sep 14, 2020
@ethanfurman ethanfurman deleted the enum-upper_case branch September 14, 2020 20:32
@ethanfurman ethanfurman restored the enum-upper_case branch September 14, 2020 20:33
@miss-islington
Copy link
Contributor

Thanks @ethanfurman for the PR 🌮🎉.. I'm working now to backport this PR to: 3.8.
🐍🍒⛏🤖

@miss-islington
Copy link
Contributor

Thanks @ethanfurman for the PR 🌮🎉.. I'm working now to backport this PR to: 3.9.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Sep 14, 2020
@ethanfurman @miss-islington
bpo-40721: add note about enum member name case (pythonGH-22231)
72b312c 
* UPPER_CASE preferred as enum members are constants
(cherry picked from commit 542e1df)

Co-authored-by: Ethan Furman <ethan@stoneleaf.us>
@bedevere-bot
Copy link

GH-22247 is a backport of this pull request to the 3.8 branch.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Sep 14, 2020
@ethanfurman @miss-islington
bpo-40721: add note about enum member name case (pythonGH-22231)
ecd147f 
* UPPER_CASE preferred as enum members are constants
(cherry picked from commit 542e1df)

Co-authored-by: Ethan Furman <ethan@stoneleaf.us>
@bedevere-bot bedevere-bot removed the needs backport to 3.9 only security fixes label Sep 14, 2020
@bedevere-bot
Copy link
8000

GH-22248 is a backport of this pull request to the 3.9 branch.

miss-islington added a commit that referenced this pull request Sep 14, 2020
@miss-islington @ethanfurman
bpo-40721: add note about enum member name case (GH-22231)
624cc10 
* UPPER_CASE preferred as enum members are constants
(cherry picked from commit 542e1df)

Co-authored-by: Ethan Furman <ethan@stoneleaf.us>
miss-islington added a commit that referenced this pull request Sep 14, 2020
@miss-islington @ethanfurman
bpo-40721: add note about enum member name case (GH-22231)
b502c76 
* UPPER_CASE preferred as enum members are constants
(cherry picked from commit 542e1df)

Co-authored-by: Ethan Furman <ethan@stoneleaf.us>
xzy3 pushed a commit to xzy3/cpython that referenced this pull request Oct 18, 2020
@ethanfurman
bpo-40721: add note about enum member name case (pythonGH-22231)
eb6dbe5 
* UPPER_CASE preferred as enum members are constants
@ethanfurman ethanfurman deleted the enum-upper_case branch April 15, 2021 14:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@ethanfurman ethanfurman

Labels
docs Documentation in the Doc dir skip news
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ethanfurman @miss-islington @bedevere-bot @the-knights-who-say-ni
0