8000 [3.9] bpo-29590: fix stack trace for gen.throw() with yield from (GH-19896) by miss-islington · Pull Request #22106 · python/cpython · GitHub
[go: up one dir, main page]
Skip to content

[3.9] bpo-29590: fix stack trace for gen.throw() with yield from (GH-19896) #22106

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 4, 2020
Merged

[3.9] bpo-29590: fix stack trace for gen.throw() with yield from (GH-19896) #22106

merged 1 commit into from
Sep 4, 2020

Conversation

miss-islington
Copy link
Contributor
@miss-islington miss-islington commented Sep 4, 2020 •
edited by bedevere-bot
Loading

  • Add failing test.

  • bpo-29590: fix stack trace for gen.throw() with yield from (GH-NNNN)

When gen.throw() is called on a generator after a "yield from", the
intermediate stack trace entries are lost. This commit fixes that.
(cherry picked from commit 8b33961)

Co-authored-by: Chris Jerdonek chris.jerdonek@gmail.com

https://bugs.python.org/issue29590

@cjerdonek @miss-islington
bpo-29590: fix stack trace for gen.throw() with yield from (pythonGH-…
63d31bc 
…19896)

* Add failing test.

* bpo-29590: fix stack trace for gen.throw() with yield from (GH-NNNN)

When gen.throw() is called on a generator after a "yield from", the
intermediate stack trace entries are lost.  This commit fixes that.
(cherry picked from commit 8b33961)

Co-authored-by: Chris Jerdonek <chris.jerdonek@gmail.com>
@miss-islington miss-islington requested a review from 1st1 as a code owner September 4, 2020 22:35
@bedevere-bot bedevere-bot mentioned this pull request Sep 4, 2020
Merged
@miss-islington
Copy link
Contributor Author

@cjerdonek and @markshannon: Status check is done, and it's a success ✅ .

@miss-islington miss-islington merged commit e92219d into python:3.9 Sep 4, 2020
@miss-islington miss-islington deleted the backport-8b33961-3.9 branch September 4, 2020 23:07
@miss-islington
Copy link
Contributor Author

@cjerdonek and @markshannon: Status check is done, and it's a success ✅ .

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Mariatta Mariatta Mariatta approved these changes

@1st1 1st1 Awaiting requested review from 1st1 1st1 is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@miss-islington @Mariatta @the-knights-who-say-ni @bedevere-bot @cjerdonek
0