8000 bpo-41706: Fix dunder operator invocation docs by wchargin · Pull Request #22084 · python/cpython · GitHub
[go: up one dir, main page]
Skip to content

bpo-41706: Fix dunder operator invocation docs #22084

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 4, 2021
Merged

bpo-41706: Fix dunder operator invocation docs #22084

merged 1 commit into from
Aug 4, 2021

Conversation

wchargin
Copy link
Contributor
@wchargin wchargin commented Sep 3, 2020 •
edited by bedevere-bot
Loading

The expression x + y is evaluated using type(x).__add__, which may
differ from x.__add__ if the __add__ attribute has been directly
assigned on the instance.

Demonstration:

class C:
    def __add__(self, other):
        return "from class"

c = C()
print(c + c)  # prints "from class"

c.__add__ = lambda other: "from instance"
print(c.__add__(c))  # prints "from instance"
print(type(c).__add__(c, c))  # prints "from class"

print(c + c)  # prints "from class"!

wchargin-branch: dunder-op-invocation-docs

https://bugs.python.org/issue41706

@wchargin
bpo-41706: Fix dunder operator invocation docs
aacce81 
The expression `x + y` is evaluated using `type(x).__add__`, which may
differ from `x.__add__` if the `__add__` attribute has been directly
assigned on the instance.

Demonstration:

```python
class C:
    def __add__(self, other):
        return "from class"

c = C()
print(c + c)  # prints "from class"

c.__add__ = lambda other: "from instance"
print(c.__add__(c))  # prints "from instance"
print(type(c).__add__(c, c))  # prints "from class"

print(c + c)  # prints "from class"!
```

wchargin-branch: dunder-op-invocation-docs
wchargin-source: 543786396ecba124a332357c771cfd6b20493abe
@bedevere-bot bedevere-bot added docs Documentation in the Doc dir awaiting review labels Sep 3, 2020
@wchargin
Copy link
Contributor Author
wchargin commented Sep 3, 2020

Verified that doc updates render correctly in the build output from the
GitHub Action.

@ammaraskar
Copy link
Member

@brettcannon Do you have an opinion on this tweak to the documentation since you wrote the desugarring blog posts?

@brettcannon brettcannon closed this Aug 4, 2021
@brettcannon brettcannon reopened this Aug 4, 2021
@brettcannon brettcannon merged commit 80f33f2 into python:main Aug 4, 2021
@brettcannon
Copy link
Member

Thanks!

@wchargin wchargin deleted the wchargin-dunder-op-invocation-docs branch August 4, 2021 20:45
@wchargin
Copy link
Contributor Author
wchargin commented Aug 4, 2021

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brettcannon brettcannon brettcannon approved these changes

Assignees
No one assigned
Labels
docs Documentation in the Doc dir
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@wchargin @ammaraskar @brettcannon @the-knights-who-say-ni @bedevere-bot
0