8000 bpo-41638: Improve ProgrammingError message for absent parameter. by serhiy-storchaka · Pull Request #21999 · python/cpython · GitHub
[go: up one dir, main page]
Skip to content

bpo-41638: Improve ProgrammingError message for absent parameter. #21999

8000
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 4, 2020
Merged

bpo-41638: Improve ProgrammingError message for absent parameter. #21999

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9819b6f
bpo-41638: Improve ProgrammingError message for absent parameter.
serhiy-storchaka Aug 29, 2020
8d5f67e
Update the NEWS entry.
serhiy-storchaka Aug 30, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
bpo-41638: Improve ProgrammingError message for absent parameter. 
It contains now the name of the parameter instead of its index when parameters
are supplied as a dict.
  • Loading branch information
@serhiy-storchaka
serhiy-storchaka committed Aug 29, 2020
commit 9819b6fc8e02d964911d391ef784eb0c9ada84d3
3 changes: 3 additions & 0 deletions Misc/NEWS.d/next/Library/2020-08-29-16-45-12.bpo-41638.iZfW5N.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
ProgrammingError message for absent parameter in :mod:`sqlite3`
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ProgrammingError -> :exc:`sqlite3.ProgrammingError`

contains now the name of the parameter instead of its index when parameters
are supplied as a dict.
2 changes: 1 addition & 1 deletion Modules/_sqlite/statement.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -295,7 +295,7 @@ void pysqlite_statement_bind_parameters(pysqlite_Statement* self, PyObject* para
Py_DECREF(binding_name_obj);
if (!current_param) {
if (!PyErr_Occurred() || PyErr_ExceptionMatches(PyExc_LookupError)) {
PyErr_Format(pysqlite_ProgrammingError, "You did not supply a value for binding %d.", i);
PyErr_Format(pysqlite_ProgrammingError, "You did not supply a value for binding parameter :%s.", binding_name);
}
return;
}
Expand Down
0