bpo-41602: raise SIGINT exit code on KeyboardInterrupt from pymain_run_module #21956
Conversation
e3c009e to
ec2856c
Compare
d2d0588 to
ce4601a
Compare
|
Requesting review from @vstinner -- since the actual fix was mine and I arrived at that through trial and error. Also, @vstinner do you think this can safely be backported to 3.8 and 3.9? IOW is it merely a bug or is the change in exit code (from 1 to SIGINT) significant enough to consider it a feature? (@graingert There's no documentation, is that right?) |
Misc/NEWS.d/next/Tests/2020-08-25-19-25-36.bpo-41602.Z64s0I.rst
Outdated
Show resolved
Hide resolved
|
@graingert I am waiting for your response (e.g. a new commit) in response to Victor's review. Am I mistaken? |
d2045de to
4486dcd
Compare
…run-module-sigint
Co-authored-by: Victor Stinner <vstinner@python.org>
| @@ -0,0 +1 @@ | |||
| Add tests for SIGINT handling in the runpy module. | |||
There was a problem hiding this comment.
| Add tests for SIGINT handling in the runpy module. | |
| Raise SIGINT exit code on KeyboardInterrupt from pymain_run_module |
|
@gvanrossum: Please replace |
|
@ambv I think this needs backporting to v3.8 and v3.9 |
|
Thanks @graingert for the PR, and @gvanrossum for merging it 🌮🎉.. I'm working now to backport this PR to: 3.9. |
|
Thanks @graingert for the PR, and @gvanrossum for merging it 🌮🎉.. I'm working now to backport this PR to: 3.8. |
|
Sorry, @graingert and @gvanrossum, I could not cleanly backport this to |
|
Sorry @graingert and @gvanrossum, I had trouble checking out the |
…ain_run_module (pythonGH-21956) Closes bpo issue 41602. (cherry picked from commit a68a2ad) Co-authored-by: Thomas Grainger <tagrain@gmail.com>
|
GH-22397 is a backport of this pull request to the 3.9 branch. |
* origin/master: (27 commits) bpo-41428: Fix compiler warnings in unionobject.c (pythonGH-22388) bpo-41654: Fix compiler warning in MemoryError_dealloc() (pythonGH-22387) bpo-41833: threading.Thread now uses the target name (pythonGH-22357) bpo-30155: Add macros to get tzinfo from datetime instances (pythonGH-21633) bpo-33822: Update IDLE section of What's New 3.8 (pythonGH-22383) bpo-41844: Add IDLE section to What's New 3.9 (GN-22382) bpo-41841: Prepare IDLE News for 3.10 (pythonGH-22379) bpo-37779 : Add information about the overriding behavior of ConfigParser.read (pythonGH-15177) bpo-40170: Use inline _PyType_HasFeature() function (pythonGH-22375) bpo-40941: Fix stackdepth compiler warnings (pythonGH-22377) bpo-40941: Fix fold_tuple_on_constants() compiler warnings (pythonGH-22378) bpo-40521: Fix PyUnicode_InternInPlace() (pythonGH-22376) bpo-41834: Remove _Py_CheckRecursionLimit variable (pythonGH-22359) bpo-1635741, unicodedata: add ucd_type parameter to UCD_Check() macro (pythonGH-22328) bpo-1635741: Port _lsprof extension to multi-phase init (PEP 489) (pythonGH-22220) bpo-41513: Improve order of adding fractional values. Improve variable names. (pythonGH-22368) bpo-41816: `StrEnum.__str__` is `str.__str__` (pythonGH-22362) bpo-35764: Rewrite the IDLE Calltips doc section (pythonGH-22363) bpo-41810: Reintroduce `types.EllipsisType`, `.NoneType` & `.NotImplementedType` (pythonGH-22336) bpo-41602: raise SIGINT exit code on KeyboardInterrupt from pymain_run_module (python#21956) ...
|
@ambv do you agree that this should be backported? |
|
Yes, I made the backport to 3.9. 3.8 I'm less convinced due to the import-based conflicts in the tests. |
|
GH-22398 is a backport of this pull request to the 3.8 branch. |
…ain_run_module (pythonGH-21956) Closes bpo issue 41602. (cherry picked from commit a68a2ad) Co-authored-by: Thomas Grainger <tagrain@gmail.com>
…ain_run_module (pythonGH-21956) (python#22397) Closes bpo issue 41602. (cherry picked from commit a68a2ad) Co-authored-by: Thomas Grainger <tagrain@gmail.com>
…n_module (python#21956) Closes bpo issue 41602
https://bugs.python.org/issue41602