8000 bpo-41604: Don't decrement the reference count of the previous user_ptr when set_panel_usertpr fails by madebr · Pull Request #21933 · python/cpython · GitHub
[go: up one dir, main page]
Skip to content

bpo-41604: Don't decrement the reference count of the previous user_ptr when set_panel_usertpr fails #21933

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jan 31, 2021
Merged

bpo-41604: Don't decrement the reference count of the previous user_ptr when set_panel_usertpr fails #21933

merged 2 commits into from
Jan 31, 2021

Conversation

madebr
Copy link
Contributor
@madebr madebr commented Aug 21, 2020 •
edited by serhiy-storchaka
Loading

@madebr
Copy link
Contributor Author
madebr commented Aug 21, 2020 •
edited
Loading

I accidentally copied the wrong bug id,
It should be https://bugs.python.org/issue41604
I'll force push a fix tomorrow.

@madebr madebr force-pushed the panel_set_userptr branch from 64bfd04 to 39a4378 Compare August 21, 2020 13:25
@serhiy-storchaka serhiy-storchaka added needs backport to 3.8 needs backport to 3.9 only security fixes type-bug An unexpected behavior, bug, or error labels Jan 6, 2021
@serhiy-storchaka serhiy-storchaka changed the title bpo-1723038: Don't decrement the reference count of the previous user_ptr when set_panel_usertpr fails bpo-41604: Don't decrement the reference count of the previous user_ptr when set_panel_usertpr fails Jan 31, 2021
@serhiy-storchaka serhiy-storchaka merged commit 3243e8a into python:master Jan 31, 2021
@miss-islington
Copy link
Contributor

Thanks @madebr for the PR, and @serhiy-storchaka for merging it 🌮🎉.. I'm working now to backport this PR to: 3.8, 3.9.
🐍🍒⛏🤖

@miss-islington
Copy link
Contributor

Sorry, @madebr and @serhiy-storchaka, I could not cleanly backport this to 3.9 due to a conflict.
Please backport using cherry_picker on command line.
cherry_picker 3243e8a4b4b4cf321f9b28335d565742a34b1976 3.9

@miss-islington
Copy link
Contributor

Sorry @madebr and @serhiy-storchaka, I had trouble checking out the 3.8 backport branch.
Please backport using cherry_picker on command line.
cherry_picker 3243e8a4b4b4cf321f9b28335d565742a34b1976 3.8

serhiy-storchaka pushed a commit to serhiy-storchaka/cpython that referenced this pull request Jan 31, 2021
@madebr @serhiy-storchaka
[3.9] bpo-41604: Don't decrement the reference count of the previous …
e178858 
…user_ptr when set_panel_usertpr fails (pythonGH-21933).

(cherry picked from commit 3243e8a)

Co-authored-by: Anonymous Maarten <madebr@users.noreply.github.com>
@bedevere-bot
Copy link

GH-24403 is a backport of this pull request to the 3.9 branch.

@bedevere-bot bedevere-bot removed the needs backport to 3.9 only security fixes label Jan 31, 2021
@serhiy-storchaka serhiy-storchaka removed their assignment Jan 31, 2021
@madebr madebr deleted the panel_set_userptr branch January 31, 2021 19:01
serhiy-storchaka added a commit that referenced this pull request Jan 31, 2021
@serhiy-storchaka @madebr
[3.9] bpo-41604: Don't decrement the reference count of the previous …
3c8d693 
…user_ptr when set_panel_usertpr fails (GH-21933). (GH-24403)

(cherry picked from commit 3243e8a)

Co-authored-by: Anonymous Maarten <madebr@users.noreply.github.com>
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jan 31, 2021
@serhiy-storchaka @miss-islington
[3.9] bpo-41604: Don't decrement 8000 the reference count of the previous …
34d56e9 
…user_ptr when set_panel_usertpr fails (pythonGH-21933). (pythonGH-24403)

(cherry picked from commit 3243e8a)

Co-authored-by: Anonymous Maarten <madebr@users.noreply.github.com>
(cherry picked from commit 3c8d693)

Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
miss-islington added a commit that referenced this pull request Jan 31, 2021
@miss-islington @serhiy-storchaka
[3.9] bpo-41604: Don't decrement the reference count of the previous …
931263b 
…user_ptr when set_panel_usertpr fails (GH-21933). (GH-24403)

(cherry picked from commit 3243e8a)

Co-authored-by: Anonymous Maarten <madebr@users.noreply.github.com>
(cherry picked from commit 3c8d693)

Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
adorilson pushed a commit to adorilson/cpython that referenced this pull request Mar 13, 2021
@madebr @adorilson
bpo-41604: Don't decrement the reference count of the previous user_p…
78c6491 
…tr when set_panel_usertpr fails (pythonGH-21933)
@ffrederick ffrederick mannequin mentioned this pull request Apr 10, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@serhiy-storchaka serhiy-storchaka serhiy-storchaka approved these changes

Assignees
No one assigned
Labels
type-bug An unexpected behavior, bug, or error
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@madebr @miss-islington @bedevere-bot @serhiy-storchaka @the-knights-who-say-ni
0