8000 [doc] Be more clear on super() regarding multiple base classes methods by andresdelfino · Pull Request #21789 · python/cpython · GitHub
[go: up one dir, main page]

Skip to content

[doc] Be more clear on super() regarding multiple base classes methods #21789

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 29, 2021

Conversation

andresdelfino
Copy link
Contributor

At first I was going to fix the "method have" to "method has" but I think "such implementations" better conveys the different possible methods than "this method" (as there's not only one method).

Copy link
Member
@orsenthil orsenthil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@miss-islington
Copy link
Contributor

Thanks @andresdelfino for the PR, and @orsenthil for merging it 🌮🎉.. I'm working now to backport this PR to: 3.8, 3.9.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Apr 29, 2021
pythonGH-21789)

(cherry picked from commit 69a733b)

Co-authored-by: Andre Delfino <adelfino@gmail.com>
@bedevere-bot bedevere-bot removed the needs backport to 3.9 only security fixes label Apr 29, 2021
@bedevere-bot
Copy link

GH-25706 is a backport of this pull request to the 3.9 branch.

@bedevere-bot
Copy link

GH-25707 is a backport of this pull request to the 3.8 branch.

orsenthil pushed a commit that referenced this pull request Apr 29, 2021
GH-21789) (GH-25706)

(cherry picked from commit 69a733b)

Co-authored-by: Andre Delfino <adelfino@gmail.com>

Co-authored-by: Andre Delfino <adelfino@gmail.com>
orsenthil pushed a commit that referenced this pull request Apr 29, 2021
GH-21789) (GH-25707)

(cherry picked from commit 69a733b)

Co-authored-by: Andre Delfino <adelfino@gmail.com>

Co-authored-by: Andre Delfino <adelfino@gmail.com>
@andresdelfino andresdelfino deleted the fix_typo_in_super branch April 29, 2021 01:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Documentation in the Doc dir skip issue skip news
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants
0