8000 bpo-30659: Use ** for kwargs in namedtuple._replace() signature by benhoyt · Pull Request #2173 · python/cpython · GitHub
[go: up one dir, main page]

Skip to content

bpo-30659: Use ** for kwargs in namedtuple._replace() signature #2173

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 13, 2017

Conversation

benhoyt
Copy link
Contributor
@benhoyt benhoyt commented Jun 13, 2017

Note that this is purely a documentation tweak. bpo link is http://bugs.python.org/issue30659

@the-knights-who-say-ni
Copy link

Hello, and thanks for your contribution!

I'm a bot set up to make sure that the project can legally accept your contribution by verifying you have signed the PSF contributor agreement (CLA).

Unfortunately we couldn't find an account corresponding to your GitHub username on bugs.python.org (b.p.o) to verify you have signed the CLA (this might be simply due to a missing "GitHub Name" entry in your b.p.o account settings). This is necessary for legal reasons before we can look at your contribution. Please follow the steps outlined in the CPython devguide to rectify this issue.

Thanks again to your contribution and we look forward to looking at it!

@benhoyt
Copy link
Contributor Author
benhoyt commented Jun 13, 2017

FYI, I didn't have the "GitHub Name" field set in bpo, so I just set that now. I've previously signed the CLA for my os.scandir() contributions.

@Mariatta Mariatta changed the title Use ** for kwargs in namedtuple._replace() signature bpo-30659: Use ** for kwargs in namedtuple._replace() signature Jun 13, 2017
@Mariatta
Copy link
Member

Thanks @benhoyt :) CLA looks good, and I added bpo-30659 to the PR title.

@Mariatta Mariatta added the docs Documentation in the Doc dir label Jun 13, 2017
@Mariatta Mariatta merged commit 184bd82 into python:master Jun 13, 2017
@Mariatta
Copy link
Member

Thanks 🎉

@Mariatta
Copy link
Member

@benhoyt Can you backport to the other versions.
You can use cherry_picker.py

The commit hash is 184bd82ba8106785ba22f0d2477dbd08bef821fb

Thanks.

@benhoyt
Copy link
Contributor Author
benhoyt commented Jun 14, 2017

I can, but it might be a few days before I get to that (need to get a block of time and learn how to use cherry_picker.py etc). If you want to do that in the meantime, go ahead, otherwise I'll do it in the next couple of weeks.

Mariatta pushed a commit to Mariatta/cpython that referenced this pull request Jun 14, 2017
Mariatta pushed a commit to Mariatta/cpython that referenced this pull request Jun 14, 2017
Mariatta pushed a commit to Mariatta/cpython that referenced this pull request Jun 14, 2017
Mariatta added a commit that referenced this pull request Jun 14, 2017
Mariatta added a commit that referenced this pull request Jun 14, 2017
Mariatta added a commit that referenced this pull request Jun 14, 2017
@benhoyt
Copy link
Contributor Author
benhoyt commented Jun 14, 2017

Excellent, thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Documentation in the Doc dir
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants
0