8000 bpo-41219: Add audio/webm in mimetypes by cereblanco · Pull Request #21368 · python/cpython · GitHub
[go: up one dir, main page]
Skip to content

bpo-41219: Add audio/webm in mimetypes #21368

8000 New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

bpo-41219: Add audio/webm in mimetypes #21368

wants to merge 1 commit into from

Conversation

cereblanco
Copy link
@cereblanco cereblanco commented Jul 6, 2020 •
edited
Loading

bpo-41219: Add audio/webm in mimetypes

https://bugs.python.org/issue41219

@cereblanco cereblanco requested a review from a team as a code owner July 6, 2020 23:44
@the-knights-who-say-ni
Copy link

Hello, and thanks for your contribution!

I'm a bot set up to make sure that the project can legally accept this contribution by verifying everyone involved has signed the PSF contributor agreement (CLA).

Recognized GitHub username

We couldn't find a bugs.python.org (b.p.o) account corresponding to the following GitHub usernames:

@cereblanco

This might be simply due to a missing "GitHub Name" entry in one's b.p.o account settings. This is necessary for legal reasons before we can look at this contribution. Please follow the steps outlined in the CPython devguide to rectify this issue.

You can check yourself to see if the CLA has been received.

Thanks again for the contribution, we look forward to reviewing it!

@cereblanco
Copy link
Author

You can check yourself to see if the CLA has been received.

hello! i just signed but not received/approved yet.

@cereblanco cereblanco force-pushed the bpo_41219_add_audio_webm_in_mimetypes branch 2 times, most recently from 979389a to 20d5ce3 Compare July 7, 2020 00:22
@cereblanco cereblanco force-pushed the bpo_41219_add_audio_webm_in_mimetypes branch from 20d5ce3 to 960d286 Compare July 7, 2020 00:26
eamanu
eamanu reviewed Jul 7, 2020
View reviewed changes
Copy link
Contributor
@eamanu eamanu left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, I don't know mimetypes.py, but just adding this line, it's enough?

@cereblanco
Copy link
Author
cereblanco commented Jul 7, 2020 •
edited
Loading

Sorry, I don't know mimetypes.py, but just adding this line, it's enough?

yes, it is added in the dictionary of _types_map_default, which is iterated upon initialization, such that each item will be added as mime type.

@cereblanco cereblanco closed this Jul 7, 2020
@cereblanco cereblanco reopened this Jul 7, 2020
@cereblanco
Copy link
Author

Closing this PR. audio/webm also has the same extension as video/webm. Might do it in another PR.

@cereblanco cereblanco closed this Jul 7, 2020
@cereblanco cereblanco deleted the bpo_41219_add_audio_webm_in_mimetypes branch July 7, 2020 06:32
@cereblanco cereblanco restored the bpo_41219_add_audio_webm_in_mimetypes branch July 7, 2020 06:32
@cereblanco cereblanco mannequin mentioned this pull request Apr 10, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eamanu eamanu eamanu left review comments

Assignees
No one assigned
Labels
awaiting review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@cereblanco @the-knights-who-say-ni @eamanu @bedevere-bot
0