bpo-31938: Fix select.epoll.register() signature #21067

vstinner · 2020-06-23T09:46:15Z

https://bugs.python.org/issue31938

vstinner · 2020-06-23T09:50:08Z

inspect.signature() doesn't see the event_mask. Is it a bug in signature which doesn't support a signature written on two lines?

cc @serhiy-storchaka @1st1 @ambv

11:47:01 vstinner@apu$ ./python 
Python 3.10.0a0 (heads/pydoc_select:486e11db95, Jun 23 2020, 11:45:39) 
>>> import select
>>> select.epoll.register.__text_signature__
'($self, /, fd,\n         eventmask=select.EPOLLIN | select.EPOLLPRI | select.EPOLLOUT)'

>>> import inspect
>>> inspect.signature(select.epoll.register)
<Signature (self, /, fd)>

So pydoc doesn't show the whole signature:

./python -m pydoc select
(...)
     |  register(self, /, fd)
     |      Registers a new fd or raises an OSError if the fd is already registered.
     |      
     |        fd
     |          the target file descriptor of the operation
     |        eventmask
     |          a bit set composed of the various EPOLL constants
     |      
     |      The epoll interface supports all file descriptors that support poll.

vstinner · 2020-06-23T09:50:59Z

Oops, @asottile already proposed PR #21066 which is the same change. I close my PR.

bpo-31938: Fix select.epoll.register() signature

486e11d

vstinner added needs backport to 3.8 needs backport to 3.9 only security fixes labels Jun 23, 2020

the-knights-who-say-ni added the CLA signed label Jun 23, 2020

bedevere-bot added the awaiting core review label Jun 23, 2020

vstinner added the skip news label Jun 23, 2020

vstinner mentioned this pull request Jun 23, 2020

bpo-31938: Fix default-value signatures of several functions in the select module #21066

Merged

vstinner closed this Jun 23, 2020

vstinner deleted the pydoc_select branch June 23, 2020 13:28

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Uh oh!

bpo-31938: Fix select.epoll.register() signature #21067

bpo-31938: Fix select.epoll.register() signature #21067

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

bpo-31938: Fix select.epoll.register() signature #21067

bpo-31938: Fix select.epoll.register() signature #21067

Uh oh!

Conversation

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!