8000 gh-85046: Adding missing errno system symbols descriptions by YoSTEALTH · Pull Request #20665 · python/cpython · GitHub
[go: up one dir, main page]
Skip to content

gh-85046: Adding missing errno system symbols descriptions #20665

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 10 commits into from
Closed

gh-85046: Adding missing errno system symbols descriptions #20665

wants to merge 10 commits into from

Conversation

YoSTEALTH
Copy link
Contributor
@YoSTEALTH YoSTEALTH commented Jun 5, 2020 •
edited by bedevere-bot
Loading

@bedevere-bot bedevere-bot added docs Documentation in the Doc dir awaiting review labels Jun 5, 2020
@YoSTEALTH
Copy link
Contributor Author
  1. This patch could be back-ported.
  2. The source for errno.h is at https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/include/uapi/asm-generic/errno.h?h=v5.7

@YoSTEALTH YoSTEALTH marked this pull request as ready for review June 5, 2020 23:30
remilapeyre
remilapeyre suggested changes Jun 6, 2020
View reviewed changes
Copy link
Contributor
@remilapeyre remilapeyre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding some, the following ones are still missing as far as I can tell:

  • EPROCLIM
  • WSAENOTEMPTY
  • WSAEHOSTDOWN
  • WSAEADDRINUSE
  • WSAECONNABORTED
  • WSABASEERR
  • WSAEPFNOSUPPORT
  • WSAHOS
  • WSAVERNOTSUPPORTED
  • WSAECONNREFUSED
  • WSAETIMEDOUT
  • WSAEADDRNOTAVAIL
  • WSAEBADF
  • WSAEALREADY
  • WSAEISCONN
  • WSAEUSERS
  • WSANOTINITIALISED
  • WSAEREMOTE
  • WSAEINTR
  • WSAEPROTOTYPE
  • EBADARCH
  • WSAEPROCLIM
  • EPROGUNAVAIL
  • WSAENOPROTOOPT
  • WSAGETSELECTERRO
  • WSAGETASYNCERRO
  • EBADEXEC
  • WSAEFAULT
  • WSAELOOP
  • WSAGETASYNCBUFLE
  • WSAEMFILE
  • WSAEDISCON
  • ENOTACTIVE
  • EAUTH
  • WSAESOCKTNOSUPPORT
  • EPROCUNAVAIL
  • WSAMAKEASYNCREPL
  • WSAEDQUOT
  • ENEEDAUTH
  • WSAENOBUFS
  • WSAETOOMANYREFS
  • WSAEOPNOTSUPP
  • WSAENOTSOCK
  • WSASYSNOTREADY
  • WSAEPROTONOSUPPORT
  • ENOTSUP
  • WSAMAKESELECTREPL
  • ELOCKUNMAPPED
  • EBADMACHO
  • WSAN
  • WSAENAMETOOLONG
  • WSAEMSGSIZE
  • ENOPOLICY
  • WSAEINPROGRESS
  • WSAENETUNREACH
  • WSAEACCES
  • WSAENOTCONN
  • EBADRPC
  • EFTYPE
  • WSADESCRIPTIO
  • ERPCMISMATCH
  • ENOATTR
  • WSAECONNRESET
  • WSAESTALE
  • WSAGETSELECTEVEN
  • EPWROFF
  • WSASY
  • WSATR
  • WSAEINVAL
  • WSAESHUTDOWN
  • WSAENETRESET
  • EDEVERR
  • EPROGMISMATCH
  • WSAENETDOWN
  • WSAEDESTADDRREQ
  • ESHLIBVERS
  • WSAEAFNOSUPPORT
  • WSAEWOULDBLOCK
  • WSAEHOSTUNREACH

Doc/library/errno.rst
Operation not possible due to RF-kill


.. data:: EHWPOISON
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This one is not present in Modules/errnomodule.c

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks, added EHWPOISON

@YoSTEALTH
Copy link
Contributor Author

@remilapeyre I think the reason those missing errors were not added is because they are alias for linux errno, for e.g. windows WSAEWOULDBLOCK is same as linux EWOULDBLOCK and their description are the same.

@remilapeyre
Copy link
Contributor

@remilapeyre I think the reason those missing errors were not added is because they are alias for linux errno, for e.g. windows WSAEWOULDBLOCK is same as linux EWOULDBLOCK and their description are the same.

What about EAUTH for example? Shouldn't it be in the list?

@YoSTEALTH
Copy link
Contributor Author

@remilapeyre Yes, i was just looking at those and other os specific errno, i would have to add those.

@YoSTEALTH YoSTEALTH changed the title bpo-40869: Adding 123-133 errno system symbols descriptions bpo-40869: Adding missing errno system symbols descriptions Jun 6, 2020
@YoSTEALTH
Copy link
Contributor Author

I also tried adding missing windows error description but they are not really that useful to users like e.g. WSAVERNOTSUPPORTED the description is Error WSAVERNOTSUPPORTED

@remilapeyre
Copy link
Contributor

WSAVERNOTSUPPORTED

I don't know Windows well but I think you will find more information in the documentation e.g. https://docs.microsoft.com/en-us/windows/win32/winsock/windows-sockets-error-codes-2

Could we add subsections like "Those errors are specific to MacOS:"? It would break the long list and make it easier to ignore the parts of the list not applicable to our current platform.

@YoSTEALTH
Copy link
Contributor Author

@remilapeyre I have updated what description i could find. I have been adding .. availability:: Windows. so people know its only for that os. These errors i can't find any description for:

WSATR
WSABASEERR
WSAHOS
WSAGETSELECTERRO
WSAGETASYNCERRO
WSASY
WSAMAKESELECTREPL
WSADESCRIPTIO
WSAN
WSAGETSELECTEVEN
WSAGETASYNCBUFLE
WSAMAKEASYNCREPL

@YoSTEALTH
Copy link
Contributor Author

Core developer reviewer note:
There are duplicate defines like

cpython/Modules/errnomodule.c

Line 826 in f69b2b9

#ifdef ECANCELED

cpython/Modules/errnomodule.c

Line 856 in f69b2b9

#ifdef ECANCELED

should i remove one?

remilapeyre
remilapeyre approved these changes Jul 20, 2020
View reviewed changes
Copy link
Contributor
@remilapeyre remilapeyre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for making the changes @YoSTEALTH ! A core developer will make another review and answer your question.

@taleinat
Copy link
Contributor
taleinat commented Sep 25, 2020 •
edited
Loading

Core developer reviewer note:
There are duplicate defines like

cpython/Modules/errnomodule.c

Line 826 in f69b2b9

#ifdef ECANCELED

cpython/Modules/errnomodule.c

Line 856 in f69b2b9

#ifdef ECANCELED

should i remove one?

If the first one in is the "main" list, then IMO yes, remove the second one.

Just do so in a separate commit, please, to ease reviewing.

@taleinat
Copy link
Contributor

I have been adding .. availability:: Windows.

That's rather verbose, but okay IMO on a page like this which is a very technical list.

I'd still suggest breaking up the already very long list, similar to how it is in the source code file, putting OS-specific codes in separate sub-sections.

@taleinat taleinat added docs Documentation in the Doc dir and removed docs Documentation in the Doc dir labels Sep 25, 2020
@taleinat
Copy link
Contributor

With the addition of EHWPOISON, this is no longer documentation-only.

We don't detail doc-only changes in NEWS, so the NEWS entry should only mention the addition of EHWPOISON.

@taleinat taleinat removed the docs Documentation in the Doc dir label Sep 25, 2020
@YoSTEALTH
Copy link
Contributor Author

@taleinat ok, thanks for your comments, I will get to these changes on/before this coming weekend.

@YoSTEALTH
Copy link
Contributor Author

Could this be merged as is for now? Will create new PR for other changes.

@furkanonder
Copy link
Contributor

@YoSTEALTH Could you solve the conflicts?

@arhadthedev arhadthedev changed the title bpo-40869: Adding missing errno system symbols descriptions gh-85046: Adding missing errno system symbols descriptions May 10, 2023
@YoSTEALTH
Copy link
Contributor Author

I am not sure whats going on. I just don't have the time + proper setup to deal with coding issues anymore. If this issues doesn't get resolved soon, I am just going to close this PR, as is been many years.

@YoSTEALTH YoSTEALTH closed this Apr 2, 2024
@bedevere-app bedevere-app bot mentioned this pull request Nov 4, 2024
Closed
@erlend-aasland erlend-aasland mentioned this pull request Nov 6, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@remilapeyre remilapeyre remilapeyre approved these changes

Assignees
No one assigned
Labels
awaiting review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@YoSTEALTH @remilapeyre @taleinat @furkanonder @the-knights-who-say-ni @ezio-melotti @bedevere-bot
0