-
-
Notifications
You must be signed in to change notification settings - Fork 32.1k
bpo-40737: 8000 Fix possible reference leak for sqlite3 initialization #20323
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
According to the docs, PyModule_AddObject() only decrements the reference count of value _on success_. Calling code must Py_DECREF() manually on error.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm with nit comment.
Misc/NEWS.d/next/Library/2020-05-23-00-22-11.bpo-40737.iph-CM.rst
Outdated
Show resolved
Hide resolved
A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated. Once you have made the requested changes, please leave a comment on this pull request containing the phrase |
Co-authored-by: Dong-hee Na <donghee.na92@gmail.com>
Co-authored-by: Dong-hee Na <donghee.na92@gmail.com>
Co-authored-by: Dong-hee Na <donghee.na92@gmail.com>
Co-authored-by: Dong-hee Na <donghee.na92@gmail.com>
Co-authored-by: Dong-hee Na <donghee.na92@gmail.com>
Co-authored-by: Dong-hee Na <donghee.na92@gmail.com>
I have made the requested changes; please review again. |
Thanks for making the requested changes! @corona10: please review the changes made to this pull request. |
Should probably be backported to 3.9, @corona10. |
Thanks for making the requested changes! @corona10: please review the changes made to this pull request. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Last review :)
It will cause the leak!
Line 693 in a487a39
Py_INCREF(type); |
A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated. Once you have made the requested changes, please leave a comment on this pull request containing the phrase |
Co-authored-by: Dong-hee Na <donghee.na92@gmail.com>
I have made the requested changes; please review again |
Thanks for making the requested changes! @corona10: please review the changes made to this pull request. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm! Thanks for the contribution!
Thanks @erlend-aasland for the PR, and @corona10 for merging it 🌮🎉.. I'm working now to backport this PR to: 3.9. |
…thonGH-20323) (cherry picked from commit 5eb45d7) Co-authored-by: Erlend Egeberg Aasland <erlend.aasland@innova.no>
GH-20425 is a backport of this pull request to the 3.9 branch. |
Thanks for you patience and helpful comments, @corona10! |
According to the docs,
PyModule_AddObject()
only decrements thereference count of value on success. Calling code must
Py_DECREF()
manually on error.
https://bugs.python.org/issue40737