8000 bpo-38870: Use subTest in test_unparse for better error reporting by pablogsal · Pull Request #20141 · python/cpython · GitHub
[go: up one dir, main page]
Skip to content

bpo-38870: Use subTest in test_unparse for better error reporting #20141

8000 New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
May 17, 2020
Merged

bpo-38870: Use subTest in test_unparse for better error reporting #20141

merged 4 commits into from
May 17, 2020

Conversation

pablogsal
Copy link
Member
@pablogsal pablogsal commented May 17, 2020 •
edited by bedevere-bot
Loading

@pablogsal pablogsal requested a review from isidentical May 17, 2020 00:05
@bedevere-bot bedevere-bot added tests Tests in the Lib/test dir awaiting core review labels May 17, 2020
isidentical
isidentical reviewed May 17, 2020
View reviewed changes
isidentical
isidentical reviewed May 17, 2020
View reviewed changes
@pablogsal @isidentical
Update Lib/test/test_unparse.py
c6e8a43 
Co-authored-by: Batuhan Taskaya <isidentical@gmail.com>
isidentical
isidentical approved these changes May 17, 2020
View reviewed changes
Copy link
Member
@isidentical isidentical left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM (since you marked raises= as resolved)

pablogsal
pablogsal commented May 17, 2020
View reviewed changes
@pablogsal
Copy link
Member Author

(since you marked raises= as resolved)

That was an error, it should have been removed :S

@isidentical
Copy link
Member

That was an error, it should have been removed :S

Ah, I see. Thanks

@pablogsal pablogsal merged commit 6341fc7 into python:master May 17, 2020
arturoescaip pushed a commit to arturoescaip/cpython that referenced this pull request May 24, 2020
@pablogsal @arturoescaip
bpo-38870: Use subTest in test_unparse for better error reporting (py…
fcf48fc 
…thonGH-20141)
@pablogsal pablogsal deleted the unparse branch May 19, 2021 18:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@isidentical isidentical isidentical approved these changes

Assignees
No one assigned
Labels
skip news tests Tests in the Lib/test dir
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@pablogsal @isidentical @the-knights-who-say-ni @bedevere-bot
0