10000 bpo-38323: Temporarily skip close_kill_running() for MultiLoopWatcher in test_asyncio by aeros · Pull Request #20013 · python/cpython · GitHub
[go: up one dir, main page]
Skip to content

bpo-38323: Temporarily skip close_kill_running() for MultiLoopWatcher in test_asyncio #20013

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 5 commits into from
Closed

bpo-38323: Temporarily skip close_kill_running() for MultiLoopWatcher in test_asyncio #20013

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
8421f9f
Temporarily skip close_kill_running() for MultiLoopWatcher in test_as…
aeros May 8, 2020
12d7544
Fix MultiLoopWatcher name for Windows compatibility
aeros May 8, 2020
842a21c
Use self.skipTest()
aeros May 8, 2020
b210564
Add Windows platform check
aeros May 9, 2020
c42449f
Check self.Watcher instead of asyncio.get_child_watcher()
aeros May 9, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Check self.Watcher instead of asyncio.get_child_watcher() 
Co-authored-by: Chris Jerdonek <chris.jerdonek@gmail.com>
  • Loading branch information
@aeros @cjerdonek
aeros and cjerdonek committed May 9, 2020
commit c42449f035552ff03524ef6ca2e5e6bc4d4578da
7 changes: 3 additions & 4 deletions Lib/test/test_asyncio/test_subprocess.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -460,10 +460,9 @@ async def cancel_make_transport():
test_utils.run_briefly(self.loop)

def test_close_kill_running(self):
if sys.platform != "win32":
if isinstance(asyncio.get_child_watcher(),
asyncio.MultiLoopChildWatcher):
self.skipTest("Temporary skip until bpo-38323 is fixed")
if (sys.platform != "win32" and
self.Watcher == asyncio.MultiLoopChildWatcher):
self.skipTest("Temporary skip until bpo-38323 is fixed")

async def kill_running():
create = self.loop.subprocess_exec(asyncio.SubprocessProtocol,
Expand Down
0