bpo-30591: added test for textwrap backtracking #1988
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Lib/test/test_textwrap.py
Outdated
| # the last wrapped line so long that the placeholder | ||
| # cannot be added there without violence. So, textwrap | ||
| # backtracks and adds the placeholder to the penultimate | ||
| # line. This test exercises several lines that otherwise |
Member
There was a problem hiding this comment.
The last sentence is not needed. We can say the same for virtually any test.
Lib/test/test_textwrap.py
Outdated
| # have no test coverage. | ||
| text = 'Good grief Python features are advancing quickly!' | ||
| self.check_wrap(text, 12, | ||
| ['Good grief', 'Python*****'], |
Member
There was a problem hiding this comment.
Indent continuation lines as in other tests.
Contributor
Author
There was a problem hiding this comment.
Thanks for your review. Patches to indent and comment just pushed.
serhiy-storchaka
approved these changes
Jun 7, 2017
Member
There was a problem hiding this comment.
Thank you for your contribution. I confirm that the new test covers the case not covered by other tests.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added test for special case when
textwrapneeds to backtrack to add placeholder.According to my runs of nedbatchelder's coverage tool, those lines previously lacked test coverage.