We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
There was an error while loading. Please reload this page.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
https://bugs.python.org/issue27867
Sorry, something went wrong.
bpo-27867: Add a porting guide for PySlice_GetIndicesEx().
e1c76f1
There was a problem hiding this comment.
The reason will be displayed to describe this comment to others. Learn more.
Is there a typo? Maybe is considered? Also there is a whitespace before ::. I do not know if it is intentional, considering you apply the :: without a whitespace in the sentence below
::
Thank you. Yes, this is a typo. A whitespace before :: is intentional.
Fixed a typo.
66bd54b
The manual change looks good to me (could improve still), the what's new blurb is a tad confusing.
I thought about "is considered not" v.s. "is not considered" for a while, but actually the former/current version as its semantics seem more appropriate
You want to link to these functions here? It makes the sentence a bit of a roller coaster.
Could it be possible to move the "using ..." to after the code block? so:
with
if (Py [...]
using functions :c: ...
Or restructure it, so that the whole block is
"This function is considered not safe for resizable sequences. Its invocation should be replaced by a combination of :c:... and :c:... where
if (PySlice_Get[...]
is replaced by
if (PySlice_Unpack..."
Thank you, I'll restructure it.
"Function" -> "The function"
"[...] instances of :class:int" seems like an unended thoought. The double but in a row ("but if ..", "but objects") is quite confusing. Consider splitting into 2 or more sentences?
int
Merge branch 'master' into PySlice_GetIndicesEx-porting-guide
77c8373
Address review comments.
872784b
Thank you @cryvate for your review.
No problem @serhiy-storchaka . Really like what you've changed it to.
Remove length from argument list.
length
Fix the example.
d66a578
b578bd7
31b9236
Correctly fix the example.
8661b18
4d3f084
into python:master Oct 8, 2017
bedevere-bot removed the awaiting core review label Oct 8, 2017 serhiy-storchaka deleted the PySlice_GetIndicesEx-porting-guide branch October 8, 2017 09:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers dalcinl dalcinl left review comments marco-buttu marco-buttu left review comments cryvate cryvate requested changes Assignees No one assigned Labels docs Documentation in the Doc dir skip news Projects None yet Milestone No milestone Development Successfully merging this pull request may close these issues. Uh oh! There was an error while loading. Please reload this page. 6 participants
dalcinl dalcinl left review comments
marco-buttu marco-buttu left review comments
cryvate cryvate requested changes
Successfully merging this pull request may close these issues.
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
You can’t perform that action at this time. 0