8000 bpo-40334: Allow to run make regen-pegen without distutils by pablogsal · Pull Request #19684 · python/cpython · GitHub
[go: up one dir, main page]
Skip to content

bpo-40334: Allow to run make regen-pegen without distutils #19684

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 23, 2020
Merged

bpo-40334: Allow to run make regen-pegen without distutils #19684

merged 1 commit into from
Apr 23, 2020

Conversation

pablogsal
Copy link
Member
@pablogsal pablogsal commented Apr 23, 2020 •
edited by bedevere-bot
Loading

@pablogsal
Copy link
Member Author

CC: @lysnikolaou

@pablogsal
Copy link
Member Author

Sadly, we cannot support < Python3.8 because the walrus operator is used in the generated meta-parser :(

@serhiy-storchaka Would you like to skip the pegen regeneration if PYTHON_FOR_REGEN is not at least 3.8? Or maybe crash with a better error message?

@lysnikolaou
Copy link
Member

LG.

@pablogsal
Copy link
Member Author

There isn't much that we can do without a considerable redesign to allow running this with something lower than Python3.8 as the generated parser for Python heavily uses the := operator so I will land this so the rest of the reported problems are fixed and a clear error message is emitted in case you run with something lower than 3.8.

@pablogsal pablogsal merged commit 50f28de into python:master Apr 23, 2020
@pablogsal pablogsal deleted the regen_pegen branch April 23, 2020 23:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lysnikolaou lysnikolaou lysnikolaou approved these changes

@serhiy-storchaka serhiy-storchaka Awaiting requested review from serhiy-storchaka

Assignees
No one assigned
Labels
skip news
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@pablogsal @lysnikolaou @the-knights-who-say-ni @bedevere-bot
0