8000 [3.8] bpo-40214: Fix ctypes WinDLL test with insecure flags (GH-19652) by miss-islington · Pull Request #19656 · python/cpython · GitHub
[go: up one dir, main page]
Skip to content

[3.8] bpo-40214: Fix ctypes WinDLL test with insecure flags (GH-19652) #19656

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 22, 2020
Merged

[3.8] bpo-40214: Fix ctypes WinDLL test with insecure flags (GH-19652) #19656

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 3 additions & 5 deletions Lib/ctypes/test/test_loading.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -158,11 +158,9 @@ def should_fail(command):
# Relative path (but not just filename) should succeed
should_pass("WinDLL('./_sqlite3.dll')")

# XXX: This test has started failing on Azure Pipelines CI. See
# bpo-40214 for more information.
if 0:
# Insecure load flags should succeed
should_pass("WinDLL('_sqlite3.dll', winmode=0)")
# Insecure load flags should succeed
# Clear the DLL directory to avoid safe search settings propagating
should_pass("windll.kernel32.SetDllDirectoryW(None); WinDLL('_sqlite3.dll', winmode=0)")

# Full path load without DLL_LOAD_DIR shouldn't find dependency
should_fail("WinDLL(nt._getfullpathname('_sqlite3.dll'), " +
Expand Down
0