bpo-35037 Fix issue in cython project: Cython files don't compile on Mingw-w64 64-bit #19326
Conversation
|
Hello, and thanks for your contribution! I'm a bot set up to make sure that the project can legally accept this contribution by verifying everyone involved has signed the PSF contributor agreement (CLA). Recognized GitHub usernameWe couldn't find a bugs.python.org (b.p.o) account corresponding to the following GitHub usernames: This might be simply due to a missing "GitHub Name" entry in one's b.p.o account settings. This is necessary for legal reasons before we can look at this contribution. Please follow the steps outlined in the CPython devguide to rectify this issue. You can check yourself to see if the CLA has been received. Thanks again for the contribution, we look forward to reviewing it! |
|
Hi, I already signed CLA with my github account |
| Add Mingw-w64 64-bit windows machine, fix issue | ||
| in https://bugs.python.org/issue40167 |
| @@ -78,6 +78,11 @@ WIN32 is still required for the locale module. | |||
|
|
|||
|
|
|||
| /* Compiler specific defines */ | |||
| #ifdef __MINGW32__ | |||
There was a problem hiding this comment.
Please add a comment explaining why and when this is needed.
|
A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated. Once you have made the requested changes, please leave a comment on this pull request containing the phrase |
|
You should specify |
1 similar comment
|
You should specify |
|
The original author hasn't picked this up again since my comments 1.5 years ago. I think we can consider them no longer interested. Is anyone else interested in bringing this to completion? @jimboyeah? |
|
This PR can be closed, it was superceded by gh-100137 which was merged 2 months ago. |
|
@rgommers Thank you for pointing the duplicate out! Closing. |
Reference Issues/PRs
bpo-40167 https://bugs.python.org/issue40167
fixes cython project issue in cython/cython#3405
What does this implement/fix? Explain your changes.
fix Cython files don't compile on Mingw-w64 64-bit problem
https://bugs.python.org/issue40167