8000 bpo-40094: Enhance os.WIFEXITED documentation by vstinner · Pull Request #19244 · python/cpython · GitHub
[go: up one dir, main page]
Skip to content

bpo-40094: Enhance os.WIFEXITED documentation #19244

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Apr 1, 2020
Merged

bpo-40094: Enhance os.WIFEXITED documentation #19244

merged 2 commits into from
Apr 1, 2020

Conversation

vstinner
Copy link
Member
@vstinner vstinner commented Mar 31, 2020 •
edited by bedevere-bot
Loading

@bedevere-bot bedevere-bot added docs Documentation in the Doc dir awaiting core review labels Mar 31, 2020
@vstinner
Copy link
Member Author

@JulienPalard @deronnax: Would you mind to review this change? I used "man 2 waitpid" on my Fedora and combined it with the existing documentation.

Is it ok to backport such documentation enhancement to 3.7 and 3.8?

I was unhappy with WIFEXITED and WIFSIGNALED documentation. The difference between the two was unclear. I wrote this PR while working on PR #19201 documentation.

corona10
corona10 reviewed Mar 31, 2020
View reviewed changes
@vstinner
Copy link
Member Author

cc @pablogsal

corona10
corona10 approved these changes Apr 1, 2020
View reviewed changes
Copy link
Member
@corona10 corona10 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm :)

@vstinner vstinner merged commit 7c72383 into python:master Apr 1, 2020
@miss-islington
Copy link
Contributor

Thanks @vstinner for the PR 🌮🎉.. I'm working now to backport this PR to: 3.7, 3.8.
🐍🍒⛏🤖

@vstinner vstinner deleted the wifexited_doc branch April 1, 2020 13:48
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Apr 1, 2020
@vstinner @miss-islington
bpo-40094: Enhance os.WIFEXITED documentation (pythonGH-19244)
81bc8be 
(cherry picked from commit 7c72383)

Co-authored-by: Victor Stinner <vstinner@python.org>
@bedevere-bot
Copy link

GH-19277 is a backport of this pull request to the 3.8 branch.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Apr 1, 2020
@vstinner @miss-islington
bpo-40094: Enhance os.WIFEXITED documentation (pythonGH-19244)
75392fc 
(cherry picked from commit 7c72383)

Co-authored-by: Victor Stinner <vstinner@python.org>
@bedevere-bot
Copy link

GH-19278 is a backport of this pull request to the 3.7 branch.

vstinner added a commit that referenced this pull request Apr 1, 2020
@vstinner
bpo-40094: Enhance os.WIFEXITED documentation (GH-19244) (GH-19278)
c8dd641 
(cherry picked from commit 7c72383)

Co-authored-by: Victor Stinner <vstinner@python.org>
vstinner added a commit that referenced this pull request Apr 1, 2020
@miss-islington @vstinner
bpo-40094: Enhance os.WIFEXITED documentation (GH-19244) (GH-19277)
267afc2 
(cherry picked from commit 7c72383)

Co-authored-by: Victor Stinner <vstinner@python.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@corona10 corona10 corona10 approved these changes

Assignees
No one assigned
Labels
docs Documentation in the Doc dir skip news
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@vstinner @miss-islington @bedevere-bot @corona10 @the-knights-who-say-ni
0