8000 bpo-39562: Prevent collision of future and compiler flags by isidentical · Pull Request #19230 · python/cpython · GitHub
[go: up one dir, main page]
Skip to content

bpo-39562: Prevent collision of future and compiler flags #19230

New issue 8000

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 10 commits into from
Apr 22, 2020
Merged

bpo-39562: Prevent collision of future and compiler flags #19230

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
984c815
bpo-39562: Prevent collision of future and compiler flags
isidentical Mar 30, 2020
8d6d207
Add support to compile for PyCF_ALLOW_TOP_LEVEL_AWAIT
isidentical Mar 30, 2020
ebf0003
Pack valid compile flags to a mask
isidentical Mar 30, 2020
c14888d
automatically discover compiler flags from ast
isidentical Mar 30, 2020
7cd943a
Mention about change, describe tests, remove old macro
isidentical Apr 20, 2020
d1094d6
Apply suggestions
isidentical Apr 20, 2020
560a100
Mention clashing variables, remove old comment
isidentical Apr 20, 2020
5f8018b
Add a noticement header, use dicts for tests
isidentical Apr 21, 2020
b225c61
Update Include/compile.h
vstinner Apr 21, 2020
0b8936e
Merge branch 'master' into bpo-39562-2
isidentical Apr 22, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Mention clashing variables, remove old comment
  • Loading branch information
@isidentical
isidentical committed Apr 20, 2020
commit 560a100ba25bb46ad8031aadf12fb969136b013c
3 changes: 2 additions & 1 deletion Doc/whatsnew/3.9.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -828,7 +828,8 @@ Changes in the Python API
(Contributed by Serhiy Storchaka in :issue:`40257`.)

* The constant values of future flags in the :mod:`__future__` module
is updated in order to prevent collision with compiler flags.
is updated in order to prevent collision with compiler flags. Previously
``PyCF_ALLOW_TOP_LEVEL_AWAIT`` was clashing with ``CO_FUTURE_DIVISION``.
(Contributed by Batuhan Taskaya in :issue:`39562`)

CPython bytecode changes
Expand Down
1 change: 0 additions & 1 deletion Include/code.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -88,7 +88,6 @@ typedef struct {
#define CO_ITERABLE_COROUTINE 0x0100
#define CO_ASYNC_GENERATOR 0x0200

/* These are no longer used. */
/* bpo-39562: These constant values are changed in Python 3.9
to prevent collision with compiler flags. */
#define CO_FUTURE_DIVISION 0x20000
Expand Down
0