8000 bpo-40112: Fix logic to determine if xlc is ccompiler by aixtools · Pull Request #19225 · python/cpython · GitHub
[go: up one dir, main page]
Skip to content

bpo-40112: Fix logic to determine if xlc is ccompiler #19225
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merged
merged 2 commits into from
Apr 3, 2020
Merged

bpo-40112: Fix logic to determine if xlc is ccompiler #19225

merged 2 commits into from
Apr 3, 2020

Conversation

aixtools
Copy link
Contributor
@aixtools aixtools commented Mar 30, 2020 •
edited
Loading

https://bugs.python.org/issue40112

No need for a NEWS entry - I think.

@bedevere-bot bedevere-bot added tests Tests in the Lib/test dir awaiting review labels Mar 30, 2020
vstinner
vstinner reviewed Mar 30, 2020
View reviewed changes
@aixtools
Copy link
Contributor Author
aixtools commented Apr 3, 2020

Is a NEWS blurb required?

@vstinner
Copy link
Member
vstinner commented Apr 3, 2020

Is a NEWS blurb required?

For tests changes, it's fine to not document them.
-->
@vstinner vstinner merged commit 76db37b into python:master Apr 3, 2020
@aixtools aixtools deleted the bpo-40112-xlc-search-cpp branch April 3, 2020 15:15
@miss-islington
Copy link
Contributor

Thanks @aixtools for the PR, and @vstinner for merging it 🌮🎉.. I'm working now to backport this PR to: 3.8.
🐍🍒⛏🤖

@bedevere-bot
Copy link

GH-19408 is a backport of this pull request to the 3.8 branch.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Apr 7, 2020
@aixtools @miss-islington
bpo-40112: distutils test_search_cpp: Fix logic to determine if C com…
0401cb1 
…piler is xlc on AIX (pythonGH-19225)

(cherry picked from commit 76db37b)

Co-authored-by: Michael Felt <aixtools@users.noreply.github.com>
@miss-islington
Copy link
Contributor

Thanks @aixtools for the PR, and @vstinner for merging it 🌮🎉.. I'm working now to backport this PR to: 3.8.
🐍🍒⛏🤖

@miss-islington
Copy link
Contributor

Sorry @aixtools and @vstinner, I had trouble checking out the 3.8 backport branch.
Please backport using cherry_picker on command line.
cherry_picker 76db37b1d37a9daadd9e5b320f2d5a53cd1352ec 3.8

@bedevere-bot
Copy link

GH-19444 is a backport of this pull request to the 3.8 branch.

vstinner added a commit that referenced this pull request Apr 9, 2020
@vstinner @aixtools
bpo-40112: distutils test_search_cpp: Fix logic to determine if C com…
cd8e1da 
…piler is xlc on AIX (GH-19225) (GH-19444)

(cherry picked from commit 76db37b)

Co-authored-by: Michael Felt <aixtools@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vstinner vstinner vstinner left review comments

Assignees

@vstinner vstinner

Labels
skip news tests Tests in the Lib/test dir
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@aixtools @vstinner @miss-islington @bedevere-bot @the-knights-who-say-ni
0