10000 bpo-40013: Added documentation to csv.DictReader restval by juhanakristian · Pull Request #19099 · python/cpython · GitHub
[go: up one dir, main page]
Skip to content

bpo-40013: Added documentation to csv.DictReader restval #19099

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 24, 2020
Merged

bpo-40013: Added documentation to csv.DictReader restval #19099

merged 1 commit into from
Mar 24, 2020

Conversation

juhanakristian
Copy link
Contributor
@juhanakristian juhanakristian commented Mar 21, 2020 •
edited by bedevere-bot
Loading

@bedevere-bot bedevere-bot added docs Documentation in the Doc dir awaiting review labels Mar 21, 2020
aeros
aeros approved these changes Mar 22, 2020
View reviewed changes
Copy link
Contributor
@aeros aeros left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR @brandfilt, LGTM. The docs for DictReader should definitely explain the purpose of the restval parameter.

tirkarthi
tirkarthi approved these changes Mar 24, 2020
View reviewed changes
Copy link
Member
@tirkarthi tirkarthi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks.

@tirkarthi tirkarthi merged commit 4b3252c into python:master Mar 24, 2020
@miss-islington
Copy link
Contributor

Thanks @brandfilt for the PR, and @tirkarthi for merging it 🌮🎉.. I'm working now to backport this PR to: 3.7, 3.8.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Mar 24, 2020
@juhanakristian @miss-islington
bpo-40013: Clarify documentation of restval in csv.DictReader (python…
67e1b26 
…GH-19099)

(cherry picked from commit 4b3252c)

Co-authored-by: Juhana Jauhiainen <juhana.jauhiainen@gmail.com>
@bedevere-bot
Copy link

GH-19141 is a backport of this pull request to the 3.8 branch.

@bedevere-bot
Copy link

GH-19142 is a backport of this pull request to the 3.7 branch.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Mar 24, 2020
@juhanakristian @miss-islington
bpo-40013: Clarify documentation of restval in csv.DictReader (python…
c7d03be 
…GH-19099)

(cherry picked from commit 4b3252c)

Co-authored-by: Juhana Jauhiainen <juhana.jauhiainen@gmail.com>
tirkarthi pushed a commit that referenced this pull request Mar 25, 2020
@miss-islington @juhanakristian
bpo-40013: Clarify documentation of restval in csv.DictReader (GH-19099…
2227c1a 
…) (GH-19141)

(cherry picked from commit 4b3252c)


Co-authored-by: Juhana Jauhiainen <juhana.jauhiainen@gmail.com>
tirkarthi pushed a commit that referenced this pull request Mar 25, 2020
@miss-islington @juhanakristian
bpo-40013: Clarify documentation of restval in csv.DictReader (GH-19099…
e5527f0 
…) (GH-19142)

(cherry picked from commit 4b3252c)


Co-authored-by: Juhana Jauhiainen <juhana.jauhiainen@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tirkarthi tirkarthi tirkarthi approved these changes

@aeros aeros aeros approved these changes

Assignees
No one assigned
Labels
docs Documentation in the Doc dir skip news
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@juhanakristian @miss-islington @bedevere-bot @tirkarthi @aeros @the-knights-who-say-ni
0