10000 bpo-40000: Improve AST validation for invalid constant nodes by isidentical · Pull Request #19055 · python/cpython · GitHub
[go: up one dir, main page]
Skip to content

bpo-40000: Improve AST validation for invalid constant nodes #19055

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Mar 19, 2020
Merged

bpo-40000: Improve AST validation for invalid constant nodes #19055

merged 5 commits into from
Mar 19, 2020

Conversation

isidentical
Copy link
Member
@isidentical isidentical commented Mar 18, 2020 •
edited by bedevere-bot
Loading

serhiy-storchaka
serhiy-storchaka reviewed Mar 18, 2020
View reviewed changes
serhiy-storchaka
serhiy-storchaka reviewed Mar 18, 2020
View reviewed changes
@isidentical isidentical force-pushed the bpo-40000 branch 2 times, most recently from a446d52 to 3760b87 Compare March 18, 2020 15:52
serhiy-storchaka
serhiy-storchaka reviewed Mar 18, 2020
View reviewed changes
pablogsal
pablogsal reviewed Mar 19, 2020
View reviewed changes
@isidentical @pablogsal
Update Misc/NEWS.d/next/Library/2020-03-18-12-54-25.bpo-40000.FnsPZC.rst
dccc8ba 
Co-Authored-By: Pablo Galindo <Pablogsal@gmail.com>
serhiy-storchaka
serhiy-storchaka reviewed Mar 19, 2020
View reviewed changes
Lib/test/test_ast.py Outdated
ast.fix_missing_locations(e)
with self.assertRaisesRegex(
TypeError, "invalid type in Constant: type"
) as cm:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cm is not used.

@serhiy-storchaka
Copy link
Member

👍

@pablogsal
Copy link
Member

Thanks, @isidentical! 🎉

@pablogsal pablogsal merged commit 0ac59f9 into python:master Mar 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@serhiy-storchaka serhiy-storchaka serhiy-storchaka approved these changes

@pablogsal pablogsal pablogsal approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@isidentical @serhiy-storchaka @pablogsal @the-knights-who-say-ni @bedevere-bot
0