-
-
Notifications
You must be signed in to change notification settings - Fork 32.4k
bpo-30436: Fix exception raised for invalid parent. #1899
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 1 commit
Commits
Show all changes
12 commits
Select commit
Hold shift + click to select a range
965834e
bpo-30436: Fix exception raised for invalid parent.
d0e8069
Add name argument to ModuleNotFoundError call.
1697a70
Tightening up try-except, docs, cosmetic changes.
c6e7851
Drop an unnecessary 'f' prefix
brettcannon c8438b2
Add NEWS entry for bpo-30436.
6fb807e
Fix merge conflict for NEWS
brettcannon 0723016
Tweak documentation wording
brettcannon 9f2844c
Tweak exception message
brettcannon 9d9c57d
Be very explicit in exception message
brettcannon 6819f9d
Clarify exception message
brettcannon 24fb8e2
Drop a period from the exception message
brettcannon f6a75fb
Explain what the test is checking for
brettcannon File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Be very explicit in exception message
- Loading branch information
commit 9d9c57df2f6d2f9ef5ede39f8fc015297293d1cf
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should the
name
argument be passed?Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes it should! I
'llupdated the PRThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is the
AttributeError
purely from the attempt to access__path__
on the imported module? If so then the__import__()
call should go outside thetry
block to limit the scope of what will have anAttributeError
caught. If there's another potential trigger of theAttributeError
then we have a bigger problem. ;)