8000 Deleting duplicates in itertoolsmodule.c by AlphaHot · Pull Request #18958 · python/cpython · GitHub
[go: up one dir, main page]
Skip to content

Deleting duplicates in itertoolsmodule.c #18958

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 23, 2020
Merged

Deleting duplicates in itertoolsmodule.c #18958

merged 1 commit into from
Mar 23, 2020

Conversation

AlphaHot
Copy link
Contributor

If I am wrong, please explain to me why the code is duplicated?

@AlphaHot
Deleting duplicates in itertoolsmodule.c
4f3f925 
If I am wrong, please explain to me why the code is duplicated?
@the-knights-who-say-ni
Copy link

Hello, and thanks for your contribution!

I'm a bot set up to make sure that the project can legally accept this contribution by verifying everyone involved has signed the PSF contributor agreement (CLA).

Recognized GitHub username

We couldn't find a bugs.python.org (b.p.o) account corresponding to the following GitHub usernames:

@AlphaHot

This might be simply due to a missing "GitHub Name" entry in one's b.p.o account settings. This is necessary for legal reasons before we can look at this contribution. Please follow the steps outlined in the CPython devguide to rectify this issue.

You can check yourself to see if the CLA has been received.

Thanks again for the contribution, we look forward to reviewing it!

@brandtbucher
Copy link
Member

Thanks for your time @AlphaHot, and welcome to CPython! 😎

I assume that you've seen the bot's message about the CLA?

brandtbucher
brandtbucher approved these changes Mar 16, 2020
View reviewed changes
Copy link
Member
@brandtbucher brandtbucher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch!

@AlphaHot
Copy link
Contributor Author

@brandtbucher @rhettinger CLA done

@AlphaHot
Copy link
Contributor Author
AlphaHot commented Mar 21, 2020 •
edited
Loading

https://bugs.python.org/user34111 Contributor Agreement - signed.pdf

@brandtbucher
Copy link
Member

Thanks for signing! Unfortunately, the CLA is manually processed by someone at the PSF, so it can take a couple of business days to update.

@rhettinger
Copy link
Contributor

Thanks for attaching the CLA PDF. That will suffice.

@rhettinger rhettinger merged commit 8dd1792 into python:master Mar 23, 2020
@ned-deily
Copy link
Member

(FYI, the CLA has been processed, as the "check youself" link shows, but this PR doesn't have a bpo issue associated with it so the bot will not process it.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rhettinger rhettinger rhettinger approved these changes

@brandtbucher brandtbucher brandtbucher approved these changes

Assignees
No one assigned
Labels
skip issue skip news
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@AlphaHot @the-knights-who-say-ni @brandtbucher @rhettinger @ned-deily @bedevere-bot
0