8000 bpo-39930: Fix MSBuild detection for Build Tools by zooba · Pull Request #18938 · python/cpython · GitHub
[go: up one dir, main page]
Skip to content

bpo-39930: Fix MSBuild detection for Build Tools #18938

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Mar 11, 2020
Merged

bpo-39930: Fix MSBuild detection for Build Tools #18938

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
5a56006
bpo-39930: Fix MSBuild detection for Build Tools
zooba Mar 11, 2020
e7d917f
Additional diagnostics
zooba Mar 11, 2020
d828efc
Try another approach to searching for the redist
zooba Mar 11, 2020
daab287
Ensure version variable is left correctly set
zooba Mar 11, 2020
1845a13
Fix label
zooba Mar 11, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Additional diagnostics
  • Loading branch information
@zooba
zooba committed Mar 11, 2020
commit e7d917f85bed36c1a47125398872638ffe4afba5
4 changes: 3 additions & 1 deletion PCbuild/pyproject.props
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -215,9 +215,11 @@ public override bool Execute() {

<ItemGroup Condition="$(VCInstallDir) != ''">
<VCRuntimeDLL Include="$(VCRedistDir)\Microsoft.VC*.CRT\vcruntime*.dll" />
<_AllRedist Include="$(VCInstallDir)\Redist\**" />
</ItemGroup>

<Warning Text="vcruntime14*.dll not found under $(VCInstallDir)" Condition="@(VCRuntimeDLL) == ''" />
<Warning Text="vcruntime14*.dll not found under $(VCRedistDir)." Condition="@(VCRuntimeDLL) == ''" />
<Message Text="Found @(_AllRedist,'%0A')" Importance="high" Condition="@(VCRuntimeDLL) == ''" />
<Message Text="VCRuntimeDLL: @(VCRuntimeDLL)" Importance="high" />
</Target>
</Project>
0