8000 bpo-39930: Convert error to warning for more silent failure by zooba · Pull Request #18921 · python/cpython · GitHub
[go: up one dir, main page]
Skip to content

bpo-39930: Convert error to warning for more silent failure #18921

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 11, 2020
Merged

bpo-39930: Convert error to warning for more silent failure #18921

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
cb437c5
bpo-39330: Convert error to warning for more silent failure
zooba Mar 11, 2020
45fcf30
Make it an error to create a layout without vcruntime DLL
zooba Mar 11, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Make it an error to create a layout without vcruntime DLL
  • Loading branch information
@zooba
zooba committed Mar 11, 2020
commit 45fcf30c4bfbb66b6a3c85071f5861b63d5d9ef7
4 changes: 4 additions & 0 deletions PC/layout/main.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -173,8 +173,12 @@ def in_build(f, dest="", new_name=None):
if ns.include_stable:
yield from in_build(PYTHON_STABLE_DLL_NAME)

found_any = False
for dest, src in rglob(ns.build, "vcruntime*.dll"):
found_any = True
yield dest, src
if not found_any:
log_error("Failed to locate vcruntime DLL in the build.")

yield "LICENSE.txt", ns.build / "LICENSE.txt"

Expand Down
0