8000 Fix download.html by methane · Pull Request #18902 · python/cpython · GitHub
[go: up one dir, main page]
Skip to content

Fix download.html #18902

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Mar 11, 2020
Merged

Fix download.html #18902

merged 2 commits into from
Mar 11, 2020

Conversation

methane
Copy link
Member
@methane methane commented Mar 10, 2020

@methane
Fix download.html
6d4fdf9 
<tt> is not allowed here.
@methane methane added type-bug An unexpected behavior, bug, or error docs Documentation in the Doc dir skip issue skip news needs backport to 3.7 labels Mar 10, 2020
isidentical
isidentical reviewed Mar 10, 2020
View reviewed changes
aeros
aeros approved these changes Mar 11, 2020
View reviewed changes
Copy link
Contributor
@aeros aeros left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. The <tt> tag currently still works in most browsers, but it is obsolete. So we're better off just removing it or replacing it with the <code> tag; I think either is fine in this context.

@methane @aeros
Update Doc/tools/templates/download.html
7adde74 
Co-Authored-By: Kyle Stanley <aeros167@gmail.com>
@methane methane merged commit 39c3493 into python:master Mar 11, 2020
@methane methane deleted the fix-html branch March 11, 2020 04:23
@miss-islington
Copy link
Contributor

Thanks @methane for the PR 🌮🎉.. I'm working now to backport this PR to: 3.7, 3.8.
🐍🍒⛏🤖 I'm not a witch! I'm not a witch!

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Mar 11, 2020
@methane @miss-islington
Fix download.html (pythonGH-18902)
b4a11a1 
`<tt>` is not allowed.

Co-authored-by: Kyle Stanley <aeros167@gmail.com>
(cherry picked from commit 39c3493)

Co-authored-by: Inada Naoki <songofacandy@gmail.com>
@bedevere-bot
Copy link

GH-18914 is a backport of this pull request to the 3.8 branch.

@bedevere-bot
Copy link

GH-18915 is a backport of this pull request to the 3.7 branch.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Mar 11, 2020
@methane @miss-islington
Fix download.html (pythonGH-18902)
9439b48 
`<tt>` is not allowed.

Co-authored-by: Kyle Stanley <aeros167@gmail.com>
(cherry picked from commit 39c3493)

Co-authored-by: Inada Naoki <songofacandy@gmail.com>
miss-islington added a commit that referenced this pull request Mar 11, 2020
@miss-islington @methane
Fix download.html (GH-18902)
6ce36ed 
`<tt>` is not allowed.

Co-authored-by: Kyle Stanley <aeros167@gmail.com>
(cherry picked from commit 39c3493)

Co-authored-by: Inada Naoki <songofacandy@gmail.com>
miss-islington added a commit that referenced this pull request Mar 11, 2020
@miss-islington @methane
Fix download.html (GH-18902)
76a69dd 
`<tt>` is not allowed.

Co-authored-by: Kyle Stanley <aeros167@gmail.com>
(cherry picked from commit 39c3493)

Co-authored-by: Inada Naoki <songofacandy@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aeros aeros aeros approved these changes

@isidentical isidentical isidentical left review comments

Assignees
No one assigned
Labels
docs Documentation in the Doc dir skip issue skip news type-bug An unexpected behavior, bug, or error
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@methane @miss-islington @bedevere-bot @aeros @isidentical @the-knights-who-say-ni
0