8000 bpo-39761: dtrace build fix for Linux and non Linux systems. by devnexen · Pull Request #18672 · python/cpython · GitHub
[go: up one dir, main page]
Skip to content

bpo-39761: dtrace build fix for Linux and non Linux systems. #18672

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

bpo-39761: dtrace build fix for Linux and non Linux systems. #18672

wants to merge 1 commit into from

Conversation

devnexen
Copy link
Contributor
@devnexen devnexen commented Feb 26, 2020 •
edited by bedevere-bot
Loading

@codecov
Copy link
codecov bot commented Feb 26, 2020

Codecov Report

Merging #18672 into master will increase coverage by 2.71%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##           master   #18672       +/-   ##
===========================================
+ Coverage   79.41%   82.13%    +2.71%     
===========================================
  Files         385     1955     +1570     
  Lines      174631   584458   +409827     
  Branches        0    44477    +44477     
===========================================
+ Hits       138683   480019   +341336     
- Misses      35948    94795    +58847     
- Partials        0     9644     +9644
Impacted Files Coverage Δ
Modules/_decimal/libmpdec/umodarith.h 80.76% <0.00%> (-19.24%) ⬇️
Modules/clinic/spwdmodule.c.h 58.33% <0.00%> (-3.21%) ⬇️
Modules/clinic/resource.c.h 78.57% <0.00%> (-2.68%) ⬇️
Modules/clinic/_pickle.c.h 62.40% <0.00%> (-2.33%) ⬇️
Modules/clinic/signalmodule.c.h 71.51% <0.00%> (-2.32%) ⬇️
Python/clinic/marshal.c.h 77.77% <0.00%> (-2.23%) ⬇️
Modules/clinic/_weakref.c.h 77.77% <0.00%> (-2.23%) ⬇️
Modules/clinic/_queuemodule.c.h 78.08% <0.00%> (-2.17%) ⬇️
Modules/_multiprocessing/clinic/posixshmem.c.h 66.66% <0.00%> (-2.09%) ⬇️
Objects/clinic/moduleobject.c.h 78.94% <0.00%> (-2.01%) ⬇️
... and 1838 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d0ca9bd...d02f546. Read the comment docs.

@hroncok
Copy link
Contributor
hroncok commented Feb 27, 2020

I can verify this fixes the build on Fedora. Not sure if this is the best or even the proper fix, not sure how it affects other unix-ish systems, but it get's the job done for us.

@encukou
Copy link
Member
encukou commented Mar 3, 2020

I don't think Linux should be an exception. ISTM that the issue is not with Linux, but rather with empty DFLAGS.

@encukou
Copy link
Member
encukou commented Mar 3, 2020

See #18766 for another approach.

@ned-deily
Copy link
Member

It appears this issue was resolved with the change in #18766. Thanks for submitting the PR and sorry this remained open for so long.

@ned-deily ned-deily closed this Apr 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
awaiting review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@devnexen @hroncok @encukou @ned-deily @the-knights-who-say-ni @bedevere-bot
0