10BC0 bpo-39619 Fix os.chroot on HP-UX 11.31 by inorton · Pull Request #18495 · python/cpython · GitHub
[go: up one dir, main page]
Skip to content

bpo-39619 Fix os.chroot on HP-UX 11.31 #18495

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
benjaminp merged 3 commits into from
Feb 14, 2020
Merged

bpo-39619 Fix os.chroot on HP-UX 11.31 #18495

benjaminp merged 3 commits into from
Feb 14, 2020

Conversation

@inorton
Copy link
Contributor
@inorton inorton commented Feb 12, 2020 •
edited
Loading

Setting -D_XOPEN_SOURCE=700 on HP-UX causes system functions such as chroot to be undefined. This change stops _XOPEN_SOURCE being set on HP-UX

https://bugs.python.org/issue39619

@the-knights-who-say-ni
Copy link
the-knights-who-say-ni commented Feb 12, 2020

Hello, and thanks for your contribution!

I'm a bot set up to make sure that the project can legally accept this contribution by verifying everyone involved has signed the PSF contributor agreement (CLA).

Recognized GitHub username

We couldn't find a bugs.python.org (b.p.o) account corresponding to the following GitHub usernames:

@inorton

This might be simply due to a missing "GitHub Name" entry in one's b.p.o account settings. This is necessary for legal reasons before we can look at this contribution. Please follow the steps outlined in the CPython devguide to rectify this issue.

You can check yourself to see if the CLA has been received.

Thanks again for the contribution, we look forward to reviewing it!

@inorton
Copy link
Contributor Author
inorton commented Feb 12, 2020

On my HP system I now have a working os.chroot()

bash-4.3# ./python
Python 3.8.1 (default, Feb 12 2020, 22:51:01) [C] on hp-ux11
Type "help", "copyright", "credits" or "license" for more information.
>>> import os
>>> os.chroot("/")
>>>

@codecov
Copy link
codecov bot commented Feb 12, 2020 •
edited
Loading

Codecov Report

Merging #18495 into master will increase coverage by 0.00%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##           master   #18495     +/-   ##
=========================================
  Coverage   82.12%   82.12%             
=========================================
  Files        1956     1955      -1     
  Lines      589203   583854   -5349     
  Branches    44449    44449             
=========================================
- Hits       483863   479480   -4383     
+ Misses      95695    94731    -964     
+ Partials     9645     9643      -2
Impacted Files Coverage Δ
Lib/distutils/tests/test_bdist_rpm.py 30.00% <0.00%> (-65.00%) ⬇️
Lib/distutils/command/bdist_rpm.py 7.63% <0.00%> (-56.88%) ⬇️
Lib/test/test_urllib2net.py 76.92% <0.00%> (-13.85%) ⬇️
Lib/test/test_smtpnet.py 78.57% <0.00%> (-7.15%) ⬇️
Lib/ftplib.py 63.85% <0.00%> (-6.06%) ⬇️
Lib/test/test_ftplib.py 87.11% <0.00%> (-4.72%) ⬇️
Tools/scripts/db2pickle.py 17.82% <0.00%> (-3.97%) ⬇️
Tools/scripts/pickle2db.py 16.98% <0.00%> (-3.78%) ⬇️
Lib/test/test_socket.py 71.94% <0.00%> (-3.77%) ⬇️
Lib/test/test_asyncio/test_base_events.py 91.84% <0.00%> (-3.30%) ⬇️
... and 325 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e9e7d28...11b84c0. Read the comment docs.

@benjaminp
Copy link
Contributor
benjaminp commented Feb 13, 2020

This looks okay but please add a NEWS note and sign the CLA.

@inorton
Copy link
Contributor Author
inorton commented Feb 13, 2020 •
edited
Loading

@benjaminp will do, I've already signed the CLA last night (hang on, just squashing my commits)

@inorton
Fix os.chroot on HP-UX 11.31
11b84c0 
Setting `-D_XOPEN_SOURCE=700` on HP-UX causes system functions such as chroot to be undefined.  This change stops `_XOPEN_SOURCE` begin set on HP-UX
@inorton inorton force-pushed the enable-chroot-on-hpux branch from e7c04a5 to 11b84c0 Compare February 13, 2020 07:43
@benjaminp benjaminp merged commit a9edf44 into python:master Feb 14, 2020
@miss-islington
8000 Copy link
Contributor
miss-islington commented Feb 14, 2020

Thanks @inorton for the PR, and @benjaminp for merging it 🌮🎉.. I'm working now to backport this PR to: 3.8.
🐍🍒⛏🤖

@bedevere-bot
Copy link
bedevere-bot commented Feb 14, 2020

GH-18509 is a backport of this pull request to the 3.8 branch.

miss-islington added a commit that referenced this pull request Feb 14, 2020
@miss-islington @inorton
closes bpo-39619 Fix os.chroot on HP-UX 11.31 (GH-18495)
28fc1ba 
Setting `-D_XOPEN_SOURCE=700` on HP-UX causes system functions such as chroot to be undefined.  This change stops `_XOPEN_SOURCE` begin set on HP-UX

Co-authored-by: Benjamin Peterson <benjamin@python.org>
(cherry picked from commit a9edf44)

Co-authored-by: Ian Norton <inorton@gmail.com>
farazs-github pushed a commit to MediaTek-Labs/cpython that referenced this pull request Nov 12, 2021
Issue python#18495: MINGW: ignore main program for frozen scripts
c7851e4
Sign up for free to join this conversation on GitHub. Already have an account? Sign in t 5B5A o comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@inorton @the-knights-who-say-ni @benjaminp @miss-islington @bedevere-bot
0