8000 bpo-39507: add HTTP status 418 "I'm a Teapot" by rrhodes · Pull Request #18291 · python/cpython · GitHub
[go: up one dir, main page]
Skip to content

bpo-39507: add HTTP status 418 "I'm a Teapot" #18291

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Mar 15, 2020
Merged

bpo-39507: add HTTP status 418 "I'm a Teapot" #18291

merged 7 commits into from
Mar 15, 2020

Conversation

rrhodes
Copy link
Contributor
@rrhodes rrhodes commented Jan 31, 2020 •
edited by bedevere-bot
Loading

What?

Adding HTTP status 418 "I'm a Teapot" to HTTPStatus in http library.

Why?

HTTP status code documented in RFC 2324: Hyper Text Coffee Pot Control Protocol (HTCPCP/1.0).

https://bugs.python.org/issue39507

@the-knights-who-say-ni
Copy link

Hello, and thanks for your contribution!

I'm a bot set up to make sure that the project can legally accept this contribution by verifying everyone involved has signed the PSF contributor agreement (CLA).

CLA Missing

Our records indicate the following people have not signed the CLA:

@rrhodes

For legal reasons we need all the people listed to sign the CLA before we can look at your contribution. Please follow the steps outlined in the CPython devguide to rectify this issue.

If you have recently signed the CLA, please wait at least one business day
before our records are updated.

You can check yourself to see if the CLA has been received.

Thanks again for the contribution, we look forward to reviewing it!

@rrhodes
Copy link
Contributor Author
rrhodes commented Jan 31, 2020 •
edited
Loading

Signed the CLA now. Following the given documentation and waiting at least one US business day for this to process.

corona10
corona10 requested changes Jan 31, 2020
View reviewed changes
Copy link
Member
@corona10 corona10 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://github.com/python/cpython/blob/master/Doc/library/http.rst

The document should be updated :)

@codecov
Copy link
codecov bot commented Jan 31, 2020

Codecov Report

Merging #18291 into master will decrease coverage by 0.07%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #18291      +/-   ##
==========================================
- Coverage   82.20%   82.12%   -0.08%     
==========================================
  Files        1957     1954       -3     
  Lines      589079   583368    -5711     
  Branches    44401    44401              
==========================================
- Hits       484247   479096    -5151     
+ Misses      95174    94630     -544     
+ Partials     9658     9642      -16
Impacted Files Coverage Δ
Lib/distutils/tests/test_bdist_rpm.py 30.00% <0.00%> (-65.00%) ⬇️
Lib/distutils/command/bdist_rpm.py 7.63% <0.00%> (-56.88%) ⬇️
Lib/test/test_urllib2net.py 76.92% <0.00%> (-13.85%) ⬇️
Lib/test/test_smtpnet.py 78.57% <0.00%> (-12.86%) ⬇️
Lib/ftplib.py 63.85% <0.00%> (-6.06%) ⬇️
Lib/test/test_ftplib.py 87.11% <0.00%> (-4.72%) ⬇️
Lib/dbm/__init__.py 66.66% <0.00%> (-4.45%) ⬇️
Tools/scripts/db2pickle.py 17.82% <0.00%> (-3.97%) ⬇️
Lib/test/test_socket.py 71.94% <0.00%> (-3.87%) ⬇️
Tools/scripts/pickle2db.py 16.98% <0.00%> (-3.78%) ⬇️
... and 313 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 58a4054...043570a. Read the comment docs.

@rrhodes
Copy link
Contributor Author
rrhodes commented Jan 31, 2020

Only outstanding action: waiting at least one business day for CLA records to update to include me.

@rrhodes
Copy link
Contributor Author
rrhodes commented Jan 31, 2020

@corona10, I think I’ve completed all outstanding tasks: CLA signed and all checks have passed. Anything further you require from me?

corona10
corona10 requested changes Feb 1, 2020
View reviewed changes
Copy link
Member
@corona10 corona10 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rrhodes
Copy link
Contributor Author
rrhodes commented Feb 26, 2020

How long typically before a core developer is available to review and approve?

@corona10 corona10 requested a review from vadmium February 26, 2020 13:31
@corona10
Copy link
Member
corona10 commented Feb 26, 2020 •
edited
Loading
8000

@vadmium
Martin, Can you please take a look at this issue and also for PR as the core developer?

@serhiy-storchaka serhiy-storchaka added the type-feature A feature request or enhancement label Mar 14, 2020
@serhiy-storchaka
Copy link
Member

Thank you for your contribution @rrhodes.

Please add the versionadded directive in the module documentation and a What's New entry (like in #18294).

serhiy-storchaka
serhiy-storchaka approved these changes Mar 15, 2020 8000
View reviewed changes
Copy link
Member
@serhiy-storchaka serhiy-storchaka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@rrhodes
Copy link
Contributor Author
rrhodes commented Mar 15, 2020

Thank you for the feedback and approval, @serhiy-storchaka. Do you have permissions to merge?

@serhiy-storchaka serhiy-storchaka merged commit 61ac612 into python:master Mar 15, 2020
sthagen added a commit to sthagen/python-cpython that referenced this pull request Mar 15, 2020
@sthagen
Merge pull request #332 from python/master
501b147 
bpo-39507: Add HTTP status 418 "I'm a Teapot" (pythonGH-18291)
@smallwat3r smallwat3r mentioned this pull request Sep 11, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@corona10 corona10 corona10 requested changes

@serhiy-storchaka serhiy-storchaka serhiy-storchaka approved these changes

@vadmium vadmium Awaiting requested review from vadmium

Assignees
No one assigned
Labels
type-feature A feature request or enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@rrhodes @the-knights-who-say-ni @corona10 @serhiy-storchaka @bedevere-bot
0